LayoutTests/fast/css/calc-rounding.html - Issue 845313010: Allow Length::nonNanCalculatedValue to take a LayoutUnit

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/calc-rounding.html

Issue 845313010: Allow Length::nonNanCalculatedValue to take a LayoutUnit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make nonNanCalculatedValue use LayoutUnit Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <style>

	2 #outerDiv, #innerDiv, #remainderDiv

	3 {

	4 background-color: green;

	5 height: 100.5px;

	6 }

	7 #outerDiv

	8 {

	9 width: 100.5px;

	10 background-color: red;

	11 }

	12 #innerDiv {

	13 width: calc(100% - 10.5px);

	14 float: left;

	15 }

	16 #remainderDiv

	17 {

	18 width: 10.5px;

	19 float: left;

	20 }

	21 </style>
	Julien - ping for review 2015/01/26 10:55:22 Let's add a description of what this is testing. T Let's add a description of what this is testing. The condition for passing should also be added, unless it's converted to a check-layout.js file (see below).
	22 <div id="outerDiv">

	23 <div id="innerDiv"></div>

	24 <div id="remainderDiv"></div>
	Julien - ping for review 2015/01/26 10:55:22 AFAICT this could be a check-layout.js test as wha AFAICT this could be a check-layout.js test as what this is trying to do is measure the size of the 2 inner divs. The upside is that this would be clearer and faster.
	25 </div>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css/calc-rounding-expected.html » ('j') | no next file with comments »