components/policy/core/common/cloud/device_management_service.cc - Issue 845313008: Refactored device status uploading out of policy fetch infrastructure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/device_management_service.cc

Issue 845313008: Refactored device status uploading out of policy fetch infrastructure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/device_management_service.h ('k') | components/policy/core/common/cloud/mock_cloud_policy_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/device_management_service.cc

diff --git a/components/policy/core/common/cloud/device_management_service.cc b/components/policy/core/common/cloud/device_management_service.cc

index 4e88ccd7a9f587adc7e52d10604cf3ccecffe6a2..37c45dde6cdb19a36a04e621c718f8a6534204cb 100644

--- a/components/policy/core/common/cloud/device_management_service.cc

+++ b/components/policy/core/common/cloud/device_management_service.cc

@@ -125,6 +125,8 @@ const char* JobTypeToRequestType(DeviceManagementRequestJob::JobType type) {

return dm_protocol::kValueRequestUploadCertificate;

case DeviceManagementRequestJob::TYPE_DEVICE_STATE_RETRIEVAL:

return dm_protocol::kValueRequestDeviceStateRetrieval;

+ case DeviceManagementRequestJob::TYPE_UPLOAD_STATUS:

+ return dm_protocol::kValueRequestUploadStatus;

}

NOTREACHED() << "Invalid job type " << type;

return "";