Add small flate decode unit test.

Add small flate decode unit test.

As we remove flate encoded sections from test cases (to
promote clarity), we should first have a simple unit test
for the underlying functionality.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/f9cfdda45319f7c0d5f6337661562fd3a6dc0f57

[Tom Sepez, 2015-02-24 19:09:11]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-02-24 19:09:35]

Lei, please review. Might as well land this. Thanks.

[Lei Zhang, 2015-02-24 20:31:25]

https://codereview.chromium.org/845313006/diff/60001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/845313006/diff/60001/BUILD.gn#newcode805
BUILD.gn:805: "core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp",
nit: fp before fx

https://codereview.chromium.org/845313006/diff/60001/core/src/fpdfapi/fpdf_pa...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp (right):

https://codereview.chromium.org/845313006/diff/60001/core/src/fpdfapi/fpdf_pa...
core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp:1: // Copyright
2014 PDFium Authors. All rights reserved.
2015

https://codereview.chromium.org/845313006/diff/60001/core/src/fpdfapi/fpdf_pa...
core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp:6: #include
<cstring>
nit: c before s

https://codereview.chromium.org/845313006/diff/60001/core/src/fpdfapi/fpdf_pa...
core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp:18: { (const
unsigned char*)input, sizeof(input) - 1, \
I don't think sizeof() works correctly here, because it's taking the size of
|input|, which is a const unsigned char pointer.

[Tom Sepez, 2015-02-24 20:44:19]

https://codereview.chromium.org/845313006/diff/60001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/845313006/diff/60001/BUILD.gn#newcode805
BUILD.gn:805: "core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp",
On 2015/02/24 20:31:25, Lei Zhang wrote:
> nit: fp before fx

Done.  Also fixed some ordering issues in .GYP file so that they match.

https://codereview.chromium.org/845313006/diff/60001/core/src/fpdfapi/fpdf_pa...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp (right):

https://codereview.chromium.org/845313006/diff/60001/core/src/fpdfapi/fpdf_pa...
core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp:1: // Copyright
2014 PDFium Authors. All rights reserved.
On 2015/02/24 20:31:25, Lei Zhang wrote:
> 2015

Done.

https://codereview.chromium.org/845313006/diff/60001/core/src/fpdfapi/fpdf_pa...
core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp:6: #include
<cstring>
On 2015/02/24 20:31:25, Lei Zhang wrote:
> nit: c before s

Done.

https://codereview.chromium.org/845313006/diff/60001/core/src/fpdfapi/fpdf_pa...
core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp:18: { (const
unsigned char*)input, sizeof(input) - 1, \
On 2015/02/24 20:31:25, Lei Zhang wrote:
> I don't think sizeof() works correctly here, because it's taking the size of
> |input|, which is a const unsigned char pointer.

Actually, |input|, the macro parameter, is a string literal.  Were you looking
at |input|, the struct member?  I've renamed to make this clearer.

[Lei Zhang, 2015-02-24 22:44:45]

lgtm

https://codereview.chromium.org/845313006/diff/60001/core/src/fpdfapi/fpdf_pa...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp (right):

https://codereview.chromium.org/845313006/diff/60001/core/src/fpdfapi/fpdf_pa...
core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp:18: { (const
unsigned char*)input, sizeof(input) - 1, \
On 2015/02/24 20:44:19, Tom Sepez wrote:
> On 2015/02/24 20:31:25, Lei Zhang wrote:
> > I don't think sizeof() works correctly here, because it's taking the size of
> > |input|, which is a const unsigned char pointer.
> 
> Actually, |input|, the macro parameter, is a string literal.  Were you looking
> at |input|, the struct member?  I've renamed to make this clearer.

Whoops, I read it wrong. Ignore.

[Tom Sepez, 2015-02-24 23:01:09]

Committed patchset #5 (id:80001) manually as
f9cfdda45319f7c0d5f6337661562fd3a6dc0f57 (tree was closed).