Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 845303004: [ozone] Enable display controller before notifying its users that it's available. (Closed)

Created:
5 years, 11 months ago by alexst (slow to review)
Modified:
5 years, 11 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ozone] Enable display controller before notifying its users that it's available. We take away the controller when we suspend, but never successfully give it back to window_delegate on resume because it's expected to be in enabled state. The result was mouse cursor not getting reset on resume. BUG=446184 NOTRY=true Committed: https://crrev.com/e2efa0f3e18b3502503b8370efb346e3bc55afae Cr-Commit-Position: refs/heads/master@{#311581}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/ozone/platform/dri/screen_manager.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
alexst (slow to review)
5 years, 11 months ago (2015-01-14 21:44:56 UTC) #2
dnicoara
lgtm
5 years, 11 months ago (2015-01-14 21:46:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845303004/1
5 years, 11 months ago (2015-01-15 00:07:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 00:08:48 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e2efa0f3e18b3502503b8370efb346e3bc55afae Cr-Commit-Position: refs/heads/master@{#311581}
5 years, 11 months ago (2015-01-15 00:10:16 UTC) #7
spang
On 2015/01/15 00:10:16, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 11 months ago (2015-01-16 23:49:37 UTC) #8
alexst (slow to review)
5 years, 11 months ago (2015-01-17 01:11:23 UTC) #9
Message was sent while issue was closed.
On 2015/01/16 23:49:37, spang wrote:
> On 2015/01/15 00:10:16, I haz the power (commit-bot) wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/e2efa0f3e18b3502503b8370efb346e3bc55afae
> > Cr-Commit-Position: refs/heads/master@{#311581}
> 
> Why is this landed under the latency bug?
> 
> There is literally nothing here that indicates it is related to that issue.

It's a fix for https://codereview.chromium.org/844343002/, which itself was a
fix to a threading issue introduced by the cursor fast path.

Powered by Google App Engine
This is Rietveld 408576698