Tag SecurityContext objects as being hosted in reserved IP ranges.

Tag SecurityContext objects as being hosted in reserved IP ranges. [1/2]

This will allow us to tag requests from those contexts in order to allow
the network stack to make intelligent decisions about whether or not it
should allow requests to reserved IP ranges go through, or whether they
should be blocked in the presence of an as-yet-to-be-introduced flag.

This patch simply adds a boolean to SecurityContext and uses it to do
the measuring that we're currently doing, rather than recalculating the
Document's state for every request.

Patch 1 - Blink:    [THIS PATCH]
Patch 2 - Chromium: https://codereview.chromium.org/852573002

BUG=378566
R=jochen@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188309

[Mike West, 2015-01-13 08:54:34]

Does this seem reasonable, Jochen?

-mike

[jochen (gone - plz use gerrit), 2015-01-13 15:04:55]

https://codereview.chromium.org/845303003/diff/40001/Source/core/dom/Document...
File Source/core/dom/DocumentInit.cpp (right):

https://codereview.chromium.org/845303003/diff/40001/Source/core/dom/Document...
Source/core/dom/DocumentInit.cpp:131: // TODO: Fix the platform API to drop the
KURL construction.
it's FIXME in blink

https://codereview.chromium.org/845303003/diff/40001/Source/core/dom/Document...
Source/core/dom/DocumentInit.cpp:134: KURL documentIP(ParsedURLString, "http://"
+ loader->response().remoteIPAddress());
https:// - be a good role model :)

otoh, why does the api not take the string? seems odd to convert to URL for no
good reason

https://codereview.chromium.org/845303003/diff/40001/Source/core/dom/Security...
File Source/core/dom/SecurityContext.h (right):

https://codereview.chromium.org/845303003/diff/40001/Source/core/dom/Security...
Source/core/dom/SecurityContext.h:59: bool isHostedInReservedIPRange() { return
m_hostedInReservedIPRange; }
const

[Mike West, 2015-01-13 15:35:38]

Thanks.

https://codereview.chromium.org/845303003/diff/40001/Source/core/dom/Document...
File Source/core/dom/DocumentInit.cpp (right):

https://codereview.chromium.org/845303003/diff/40001/Source/core/dom/Document...
Source/core/dom/DocumentInit.cpp:131: // TODO: Fix the platform API to drop the
KURL construction.
On 2015/01/13 15:04:55, jochen (slow) wrote:
> it's FIXME in blink

Done.

https://codereview.chromium.org/845303003/diff/40001/Source/core/dom/Document...
Source/core/dom/DocumentInit.cpp:134: KURL documentIP(ParsedURLString, "http://"
+ loader->response().remoteIPAddress());
On 2015/01/13 15:04:54, jochen (slow) wrote:
> https:// - be a good role model :)

Ha! Done.

> otoh, why does the api not take the string? seems odd to convert to URL for no
> good reason

Your humble API author is an idiot, basically. We don't need the KURL; we strip
it down to a host immediately upon passing it to Chromium. We did briefly use a
KURL for a naive version of this check earlier, but it's a waste now.

I was going to poke at this in a separate CL, but I guess it's just as easy to
fix it here.

[jochen (gone - plz use gerrit), 2015-01-13 15:40:52]

lgtm

[Mike West, 2015-01-13 15:52:01]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-01-13 15:52:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/845303003/60001

[commit-bot: I haz the power, 2015-01-13 18:09:12]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188309