Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Issue 845223002: Removing --renderer-assert-test command-line flag (Closed)

Created:
5 years, 11 months ago by anujsharma
Modified:
5 years, 11 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing --renderer-assert-test command-line flag BUG=447957 Committed: https://crrev.com/ab82b75dbda97e7caf83464c1c1665e72554c5b1 Cr-Commit-Position: refs/heads/master@{#311221}

Patch Set 1 #

Patch Set 2 : Fixed build errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/renderer_main.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
anujsharma
PTAL
5 years, 11 months ago (2015-01-12 07:00:49 UTC) #2
Avi (use Gerrit)
On 2015/01/12 07:00:49, anujsharma wrote: > PTAL This looks like a debugging flag. We might ...
5 years, 11 months ago (2015-01-12 16:17:45 UTC) #3
anujsharma
On 2015/01/12 16:17:45, Avi wrote: > On 2015/01/12 07:00:49, anujsharma wrote: > > PTAL > ...
5 years, 11 months ago (2015-01-13 03:09:22 UTC) #4
anujsharma
On 2015/01/13 03:09:22, anujsharma wrote: > On 2015/01/12 16:17:45, Avi wrote: > > On 2015/01/12 ...
5 years, 11 months ago (2015-01-13 03:19:02 UTC) #5
Avi (use Gerrit)
On 2015/01/13 03:19:02, anujsharma wrote: > On 2015/01/13 03:09:22, anujsharma wrote: > > On 2015/01/12 ...
5 years, 11 months ago (2015-01-13 03:40:09 UTC) #6
anujsharma
On 2015/01/13 03:40:09, Avi wrote: > On 2015/01/13 03:19:02, anujsharma wrote: > > On 2015/01/13 ...
5 years, 11 months ago (2015-01-13 03:59:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845223002/20001
5 years, 11 months ago (2015-01-13 04:00:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-13 05:43:22 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 05:45:02 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab82b75dbda97e7caf83464c1c1665e72554c5b1
Cr-Commit-Position: refs/heads/master@{#311221}

Powered by Google App Engine
This is Rietveld 408576698