Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 845203002: Don't return Windows newlines through the PDF GetSelectedText JS API (Closed)

Created:
5 years, 11 months ago by raymes
Modified:
5 years, 11 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@addMissingFeatures
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't return Windows newlines through the PDF GetSelectedText JS API Previously we used to return Windows newlines through the GetSelectedText JS API but this is fairly unexpected in JS (for example the window.getSelection() doesn't seem to return Windows newlines on Windows). Instead just return unix newline characters. BUG=415858 Committed: https://crrev.com/f8657305a9ff2516e420c2d1458b86bc30ea4d65 Cr-Commit-Position: refs/heads/master@{#311149}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M pdf/instance.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M pdf/out_of_process_instance.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
raymes
5 years, 11 months ago (2015-01-12 03:39:03 UTC) #2
Sam McNally
lgtm
5 years, 11 months ago (2015-01-12 03:48:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845203002/20001
5 years, 11 months ago (2015-01-12 03:55:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/47750) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/36405) android_chromium_gn_compile_dbg ...
5 years, 11 months ago (2015-01-12 03:57:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845203002/40001
5 years, 11 months ago (2015-01-12 04:04:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/13789)
5 years, 11 months ago (2015-01-12 05:17:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845203002/40001
5 years, 11 months ago (2015-01-12 23:11:11 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-12 23:52:37 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 23:54:06 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f8657305a9ff2516e420c2d1458b86bc30ea4d65
Cr-Commit-Position: refs/heads/master@{#311149}

Powered by Google App Engine
This is Rietveld 408576698