Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/runtime.cc

Issue 8452002: Don't allow delaying last resort GC when incremental marking is in progress. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 13501 matching lines...) Expand 10 before | Expand all | Expand 10 after
13512 if (isolate->heap()->new_space()->AddFreshPage()) { 13512 if (isolate->heap()->new_space()->AddFreshPage()) {
13513 return; 13513 return;
13514 } 13514 }
13515 // Try to do a garbage collection; ignore it if it fails. The C 13515 // Try to do a garbage collection; ignore it if it fails. The C
13516 // entry stub will throw an out-of-memory exception in that case. 13516 // entry stub will throw an out-of-memory exception in that case.
13517 isolate->heap()->CollectGarbage(failure->allocation_space()); 13517 isolate->heap()->CollectGarbage(failure->allocation_space());
13518 } else { 13518 } else {
13519 // Handle last resort GC and make sure to allow future allocations 13519 // Handle last resort GC and make sure to allow future allocations
13520 // to grow the heap without causing GCs (if possible). 13520 // to grow the heap without causing GCs (if possible).
13521 isolate->counters()->gc_last_resort_from_js()->Increment(); 13521 isolate->counters()->gc_last_resort_from_js()->Increment();
13522 isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags); 13522 isolate->heap()->CollectAllAvailableGarbage();
Erik Corry 2011/11/04 11:51:29 Perhaps we should force through one mark-sweep bef
13523 } 13523 }
13524 } 13524 }
13525 13525
13526 13526
13527 } } // namespace v8::internal 13527 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698