chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java - Issue 845193005: Tear down ContentVideoView from content-layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

Issue 845193005: Tear down ContentVideoView from content-layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Only include content_video_view.h on Android Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java ('k') | content/browser/media/android/browser_media_player_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

index c0bd1ce9291c0d96eb211ca6fbec52ee803e32e0..dcb4d5dae3ae7d76ec451bb82c4d4590f7f2fc1b 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

@@ -12,7 +12,6 @@ import org.chromium.chrome.browser.UrlUtilities;

import org.chromium.chrome.browser.contextmenu.ChromeContextMenuPopulator;

import org.chromium.chrome.browser.contextmenu.ContextMenuPopulator;

import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

-import org.chromium.content.browser.ContentVideoView;

import org.chromium.content.browser.ContentViewClient;

import org.chromium.content_public.browser.LoadUrlParams;

import org.chromium.content_public.browser.NavigationController;

@@ -127,12 +126,6 @@ public class ChromeShellTab extends Tab {

public void toggleFullscreenModeForTab(boolean enterFullscreen) {

mIsFullscreen = enterFullscreen;

super.toggleFullscreenModeForTab(enterFullscreen);

- if (!mIsFullscreen) {

- ContentVideoView videoView = ContentVideoView.getContentVideoView();

- if (videoView != null) videoView.exitFullscreen(false);

- }

}

@Override