content/shell/android/java/src/org/chromium/content_shell/Shell.java - Issue 845193005: Tear down ContentVideoView from content-layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/java/src/org/chromium/content_shell/Shell.java

Issue 845193005: Tear down ContentVideoView from content-layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unneeded include Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/android/browser_media_player_manager.cc ('K') | « content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/java/src/org/chromium/content_shell/Shell.java

diff --git a/content/shell/android/java/src/org/chromium/content_shell/Shell.java b/content/shell/android/java/src/org/chromium/content_shell/Shell.java

index 79edb4858f2b464daa694c971b9145248c946340..6c5e21a268133ce6c9e2f2dc5cb778a3340366eb 100644

--- a/content/shell/android/java/src/org/chromium/content_shell/Shell.java

+++ b/content/shell/android/java/src/org/chromium/content_shell/Shell.java

@@ -22,7 +22,6 @@ import android.widget.TextView.OnEditorActionListener;

import org.chromium.base.CalledByNative;

import org.chromium.base.JNINamespace;

-import org.chromium.content.browser.ContentVideoView;

import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.ContentViewClient;

import org.chromium.content.browser.ContentViewCore;

@@ -260,11 +259,6 @@ public class Shell extends LinearLayout {

mIsFullscreen = enterFullscreen;

LinearLayout toolBar = (LinearLayout) findViewById(R.id.toolbar);

toolBar.setVisibility(enterFullscreen ? GONE : VISIBLE);

- if (!mIsFullscreen) {

- ContentVideoView videoView = ContentVideoView.getContentVideoView();

- if (videoView != null) videoView.exitFullscreen(false);

- }

}

@CalledByNative