content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java - Issue 845193005: Tear down ContentVideoView from content-layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java

Issue 845193005: Tear down ContentVideoView from content-layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tear down ContentVideoView from content-layer Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/shell/android/java/src/org/chromium/content_shell/Shell.java » ('j') | content/shell/android/java/src/org/chromium/content_shell/Shell.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java b/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java

index ea5dd20231ab5fcd407e241a9e4a0f2c72bcb2ed..e4a1c2769c55dce4178f50e7493309a7a556278d 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java

@@ -378,8 +378,8 @@ public class ContentVideoView extends FrameLayout

}

public void exitFullscreen(boolean relaseMediaPlayer) {

- destroyContentVideoView(false);

if (mNativeContentVideoView != 0) {

+ destroyContentVideoView(false);

if (mUmaRecorded && !mPossibleAccidentalChange) {

long currentTime = System.currentTimeMillis();

long timeBeforeOrientationChange = mOrientationChangedTime - mPlaybackStartTime;