Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 845193004: Enable test coverage for --turbo-deoptimization mode. (Closed)

Created:
5 years, 11 months ago by Michael Starzinger
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enable test coverage for --turbo-deoptimization mode. R=jarin@chromium.org Committed: https://crrev.com/9fbe872137e45542b609ffe46a86379fa64ed066 Cr-Commit-Position: refs/heads/master@{#26102}

Patch Set 1 #

Patch Set 2 : Fix after rebase. #

Patch Set 3 : One more failure on ARM simulator. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -63 lines) Patch
M test/benchmarks/testcfg.py View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +7 lines, -23 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 1 chunk +7 lines, -37 lines 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/testrunner/local/testsuite.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Starzinger
PTAL. Note that this also removes --turbo-asm from the TurboFan variant because it is enabled ...
5 years, 11 months ago (2015-01-15 14:29:04 UTC) #1
Michael Achenbach
lgtm for the infra stuff.
5 years, 11 months ago (2015-01-15 14:36:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845193004/40001
5 years, 11 months ago (2015-01-16 12:26:25 UTC) #4
Jarin
lgtm
5 years, 11 months ago (2015-01-16 12:26:31 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-16 12:53:29 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 12:53:40 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9fbe872137e45542b609ffe46a86379fa64ed066
Cr-Commit-Position: refs/heads/master@{#26102}

Powered by Google App Engine
This is Rietveld 408576698