GrBatchPrototype

src/gpu/GrDrawState.cpp

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "GrDrawState.h"
 
 #include "GrBlend.h"
@@ skipping 41 matching lines @@
     fXPFactory.reset(SkRef(that.getXPFactory()));
     fColorStages = that.fColorStages;
     fCoverageStages = that.fCoverageStages;
 
     fColorProcInfoValid = that.fColorProcInfoValid;
     fCoverageProcInfoValid = that.fCoverageProcInfoValid;
     fColorCache = that.fColorCache;
     fCoverageCache = that.fCoverageCache;
     fColorPrimProc = that.fColorPrimProc;
     fCoveragePrimProc = that.fCoveragePrimProc;
+    fColorBatch = that.fColorBatch;
+    fCoverageBatch = that.fCoverageBatch;
     if (fColorProcInfoValid) {
         fColorProcInfo = that.fColorProcInfo;
     }
     if (fCoverageProcInfoValid) {
         fCoverageProcInfo = that.fCoverageProcInfo;
     }
     return *this;
 }
 
 void GrDrawState::onReset() {
     SkASSERT(0 == fBlockEffectRemovalCnt || 0 == this->numFragmentStages());
     fRenderTarget.reset(NULL);
 
     fXPFactory.reset(GrPorterDuffXPFactory::Create(SkXfermode::kSrc_Mode));
     fColorStages.reset();
     fCoverageStages.reset();
 
     fFlagBits = 0x0;
     fStencilSettings.setDisabled();
     fDrawFace = kBoth_DrawFace;
 
     fColorProcInfoValid = false;
     fCoverageProcInfoValid = false;
 
     fColorCache = GrColor_ILLEGAL;
     fCoverageCache = GrColor_ILLEGAL;
 
     fColorPrimProc = NULL;
     fCoveragePrimProc = NULL;
+
+    fColorBatch = NULL;
+    fCoverageBatch = NULL;
 }
 
 void GrDrawState::setFromPaint(const GrPaint& paint, GrRenderTarget* rt) {
     SkASSERT(0 == fBlockEffectRemovalCnt || 0 == this->numFragmentStages());
 
     fColorStages.reset();
     fCoverageStages.reset();
 
     for (int i = 0; i < paint.numColorStages(); ++i) {
         fColorStages.push_back(paint.getColorStage(i));
@@ skipping 19 matching lines @@
     this->setState(GrDrawState::kHWAntialias_StateBit, paint.isAntiAlias());
 
     fColorProcInfoValid = false;
     fCoverageProcInfoValid = false;
 
     fColorCache = GrColor_ILLEGAL;
     fCoverageCache = GrColor_ILLEGAL;
 
     fColorPrimProc = NULL;
     fCoveragePrimProc = NULL;
+
+    fColorBatch = NULL;
+    fCoverageBatch = NULL;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 
 bool GrDrawState::canUseFracCoveragePrimProc(GrColor color, const GrDrawTargetCaps& caps) const {
     if (caps.dualSourceBlendingSupport()) {
         return true;
     }
 
     this->calcColorInvariantOutput(color);
 
     // The coverage isn't actually white, its unknown, but this will produce the same effect
     // TODO we want to cache the result of this call, but we can probably clean up the interface
     // so we don't have to pass in a seemingly known coverage
     this->calcCoverageInvariantOutput(GrColor_WHITE);
     return fXPFactory->canApplyCoverage(fColorProcInfo, fCoverageProcInfo);
 }
 
 //////////////////////////////////////////////////////////////////////////////s
 
 bool GrDrawState::willEffectReadDstColor(const GrPrimitiveProcessor* pp) const {
     this->calcColorInvariantOutput(pp);
     this->calcCoverageInvariantOutput(pp);
 
     return fXPFactory->willReadDst(fColorProcInfo, fCoverageProcInfo);
 }
 
+bool GrDrawState::willEffectReadDstColor(const GrBatch* batch) const {
+    this->calcColorInvariantOutput(batch);
+    this->calcCoverageInvariantOutput(batch);
+
+    return fXPFactory->willReadDst(fColorProcInfo, fCoverageProcInfo);
+}
+
+
 void GrDrawState::AutoRestoreEffects::set(GrDrawState* ds) {
     if (fDrawState) {
         int m = fDrawState->numColorStages() - fColorEffectCnt;
         SkASSERT(m >= 0);
         fDrawState->fColorStages.pop_back_n(m);
 
         int n = fDrawState->numCoverageStages() - fCoverageEffectCnt;
         SkASSERT(n >= 0);
         fDrawState->fCoverageStages.pop_back_n(n);
         if (m + n > 0) {
@@ skipping 45 matching lines @@
 
 void GrDrawState::calcCoverageInvariantOutput(const GrPrimitiveProcessor* pp) const {
     if (!fCoverageProcInfoValid ||  fCoveragePrimProc != pp) {
         fCoverageProcInfo.calcCoverageWithPrimProc(pp, fCoverageStages.begin(),
                                                    this->numCoverageStages());
         fCoverageProcInfoValid = true;
         fCoveragePrimProc = pp;
     }
 }
 
+void GrDrawState::calcColorInvariantOutput(const GrBatch* batch) const {
+    if (!fColorProcInfoValid || fColorBatch != batch) {

[bsalomon, 2015/01/20 16:14:02]

all this storing of mutable ptrs seems very fragile. Can we move to uniqueIDs?

[joshualitt, 2015/01/20 17:03:08]

How could we assign a uniqueID to each batch without using the pointer?  I agree
its fragile, I loathe this code, and right now its only for one
call(willBlendWithDst) which is just used by NVPR.

[bsalomon, 2015/01/20 20:49:58]

I mean its fragile because two batches that exist at different times can share
an address. Unique IDs can only be shared after 4 billion batches have been
created between.

+        GrBatchOpt batchOpt;
+        batchOpt.fCanTweakAlphaForCoverage = this->canTweakAlphaForCoverage();
+        fColorProcInfo.calcColorWithBatch(batch, batchOpt, fColorStages.begin(),
+                                          this->numColorStages());
+        fColorProcInfoValid = true;
+        fColorBatch = batch;
+    }
+}
+
+void GrDrawState::calcCoverageInvariantOutput(const GrBatch* batch) const {
+    if (!fCoverageProcInfoValid ||  fCoverageBatch != batch) {
+        GrBatchOpt batchOpt;
+        batchOpt.fCanTweakAlphaForCoverage = this->canTweakAlphaForCoverage();
+        fCoverageProcInfo.calcCoverageWithBatch(batch, batchOpt, fCoverageStages.begin(),
+                                                this->numCoverageStages());
+        fCoverageProcInfoValid = true;
+        fCoverageBatch = batch;
+    }
+}
+
+
 void GrDrawState::calcColorInvariantOutput(GrColor color) const {
     if (!fColorProcInfoValid || color != fColorCache) {
         GrColorComponentFlags flags = kRGBA_GrColorComponentFlags;
         fColorProcInfo.calcWithInitialValues(fColorStages.begin(), this->numColorStages(), color,
                                              flags, false);
         fColorProcInfoValid = true;
         fColorCache = color;
     }
 }
 
 void GrDrawState::calcCoverageInvariantOutput(GrColor coverage) const {
     if (!fCoverageProcInfoValid || coverage != fCoverageCache) {
         GrColorComponentFlags flags = kRGBA_GrColorComponentFlags;
         fCoverageProcInfo.calcWithInitialValues(fCoverageStages.begin(),
                                                 this->numCoverageStages(), coverage, flags,
                                                 true);
         fCoverageProcInfoValid = true;
         fCoverageCache = coverage;
     }
 }