Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 845103004: Mojo JS Bindings: add show_image example (Closed)

Created:
5 years, 11 months ago by hansmuller
Modified:
5 years, 11 months ago
Reviewers:
hansmuller1, eseidel
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojo JS Bindings: add show_image example Add a simple example based on the window and view managers. The skydb app can now handle apps that want to embed another view. Corrected a problem in unique module name generation. An otherwise unique module name could be shadowed by a parameter name (service_provider in ViewManagerService Embed). Appended a "$" suffix to module names to avoid the collision. BUG= R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9fbbc4f0fef1187312316c0ed992342474e139f1

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -3 lines) Patch
M examples/js/README.md View 1 chunk +2 lines, -0 lines 0 comments Download
A examples/js/show_image.js View 1 chunk +53 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/debugger/debugger.h View 2 chunks +7 lines, -1 line 0 comments Download
M sky/tools/debugger/debugger.cc View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
hansmuller1
This patch includes the debugger.cc fix we talked about. Other than that, it's just a ...
5 years, 11 months ago (2015-01-12 23:47:30 UTC) #5
eseidel
lgtm
5 years, 11 months ago (2015-01-13 00:25:37 UTC) #6
hansmuller
5 years, 11 months ago (2015-01-13 00:35:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
9fbbc4f0fef1187312316c0ed992342474e139f1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698