Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Unified Diff: Source/modules/accessibility/AXTable.cpp

Issue 845103003: ASSERTION FAILED: !node || isElementOfType<const T>(*node) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Modified as per review comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXTable.cpp
diff --git a/Source/modules/accessibility/AXTable.cpp b/Source/modules/accessibility/AXTable.cpp
index 1d75f2a06fc3f7e6bdeab171aac1e4cc8762f8f8..bcd0cb9a6c5fef3c7ca4d466d44cd45e09fd2ec3 100644
--- a/Source/modules/accessibility/AXTable.cpp
+++ b/Source/modules/accessibility/AXTable.cpp
@@ -373,13 +373,15 @@ void AXTable::addChildren()
RenderTable* table = toRenderTable(m_renderer);
AXObjectCacheImpl* axCache = axObjectCache();
+ Node* tableNode = table->node();
+ if (!isHTMLTableElement(tableNode))
+ return;
+
// Add caption
- if (HTMLTableElement* tableElement = toHTMLTableElement(table->node())) {
- if (HTMLTableCaptionElement* caption = tableElement->caption()) {
- AXObject* captionObject = axCache->getOrCreate(caption);
- if (!captionObject->accessibilityIsIgnored())
- m_children.append(captionObject);
- }
+ if (HTMLTableCaptionElement* caption = toHTMLTableElement(tableNode)->caption()) {
+ AXObject* captionObject = axCache->getOrCreate(caption);
+ if (!captionObject->accessibilityIsIgnored())
+ m_children.append(captionObject);
}
// Go through all the available sections to pull out the rows and add them as children.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698