Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: sky/engine/core/rendering/RenderView.cpp

Issue 845093002: Delete an assortment of unneeded paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderView.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderView.cpp
diff --git a/sky/engine/core/rendering/RenderView.cpp b/sky/engine/core/rendering/RenderView.cpp
index fa97d8d79d578ea426740cb78e4b37ab0156b1b7..bdc18522a27a752405303a395616a5ad01c82278 100644
--- a/sky/engine/core/rendering/RenderView.cpp
+++ b/sky/engine/core/rendering/RenderView.cpp
@@ -275,28 +275,6 @@ void RenderView::paintBoxDecorationBackground(PaintInfo& paintInfo, const Layout
}
}
-void RenderView::invalidateTreeIfNeeded(const PaintInvalidationState& paintInvalidationState)
-{
- ASSERT(!needsLayout());
-
- // We specifically need to issue paint invalidations for the viewRect since other renderers
- // short-circuit on full-paint invalidation.
- LayoutRect dirtyRect = viewRect();
- if (doingFullPaintInvalidation() && !dirtyRect.isEmpty()) {
- const RenderLayerModelObject* paintInvalidationContainer = &paintInvalidationState.paintInvalidationContainer();
- mapRectToPaintInvalidationBacking(paintInvalidationContainer, dirtyRect, &paintInvalidationState);
- }
- RenderBlock::invalidateTreeIfNeeded(paintInvalidationState);
-}
-
-void RenderView::invalidatePaintForRectangle(const LayoutRect& paintInvalidationRect) const
-{
- ASSERT(!paintInvalidationRect.isEmpty());
-
- if (m_frameView)
- m_frameView->contentRectangleForPaintInvalidation(pixelSnappedIntRect(paintInvalidationRect));
-}
-
void RenderView::mapRectToPaintInvalidationBacking(const RenderLayerModelObject* paintInvalidationContainer, LayoutRect& rect, const PaintInvalidationState* state) const
{
// Apply our transform if we have one (because of full page zooming).
@@ -304,7 +282,6 @@ void RenderView::mapRectToPaintInvalidationBacking(const RenderLayerModelObject*
rect = layer()->transform()->mapRect(rect);
}
-
void RenderView::absoluteRects(Vector<IntRect>& rects, const LayoutPoint& accumulatedOffset) const
{
rects.append(pixelSnappedIntRect(accumulatedOffset, layer()->size()));
@@ -551,7 +528,6 @@ void RenderView::getSelection(RenderObject*& startRenderer, int& startOffset, Re
void RenderView::clearSelection()
{
- layer()->invalidatePaintForBlockSelectionGaps();
setSelection(0, -1, 0, -1, PaintInvalidationNewMinusOld);
}
« no previous file with comments | « sky/engine/core/rendering/RenderView.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698