sky/engine/core/rendering/RenderLayerScrollableArea.cpp - Issue 845093002: Delete an assortment of unneeded paint invalidation code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderLayerScrollableArea.cpp

Issue 845093002: Delete an assortment of unneeded paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderLayerScrollableArea.cpp

diff --git a/sky/engine/core/rendering/RenderLayerScrollableArea.cpp b/sky/engine/core/rendering/RenderLayerScrollableArea.cpp

index 6ae836f5df3924f2b5ae542657baf1decc97cfad..4ece07ed413faec6b02267ab8920820e0234f2d9 100644

--- a/sky/engine/core/rendering/RenderLayerScrollableArea.cpp

+++ b/sky/engine/core/rendering/RenderLayerScrollableArea.cpp

@@ -106,6 +106,7 @@ HostWindow* RenderLayerScrollableArea::hostWindow() const

return nullptr;

}

+// FIXME(sky): Remove

void RenderLayerScrollableArea::invalidateScrollbarRect(Scrollbar* scrollbar, const IntRect& rect)

{

IntRect scrollRect = rect;

@@ -125,8 +126,6 @@ void RenderLayerScrollableArea::invalidateScrollbarRect(Scrollbar* scrollbar, co

if (box().frameView()->isInPerformLayout())

addScrollbarDamage(scrollbar, intRect);

- else

- box().invalidatePaintRectangle(intRect);

}

bool RenderLayerScrollableArea::isActive() const

« no previous file with comments | « sky/engine/core/rendering/RenderLayer.cpp ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »