Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: sky/engine/core/rendering/RenderImage.cpp

Issue 845093002: Delete an assortment of unneeded paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBlock.cpp ('k') | sky/engine/core/rendering/RenderLayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderImage.cpp
diff --git a/sky/engine/core/rendering/RenderImage.cpp b/sky/engine/core/rendering/RenderImage.cpp
index 3d2ad38d77876c5507a3da904b06813954c7aefc..b41e8469192af929d8d363dae72ce25742fd318e 100644
--- a/sky/engine/core/rendering/RenderImage.cpp
+++ b/sky/engine/core/rendering/RenderImage.cpp
@@ -165,23 +165,6 @@ void RenderImage::paintInvalidationOrMarkForLayout(const IntRect* rect)
// early. It may be that layout hasn't even taken place once yet.
updateInnerContentRect();
}
-
- LayoutRect paintInvalidationRect;
- if (rect) {
- // The image changed rect is in source image coordinates,
- // so map from the bounds of the image to the contentsBox.
- paintInvalidationRect = enclosingIntRect(mapRect(*rect, FloatRect(FloatPoint(), m_imageResource->imageSize()), contentBoxRect()));
- // Guard against too-large changed rects.
- paintInvalidationRect.intersect(contentBoxRect());
- } else {
- paintInvalidationRect = contentBoxRect();
- }
-
- {
- // FIXME: We should not be allowing paint invalidations during layout. crbug.com/339584
- AllowPaintInvalidationScope scoper(frameView());
- invalidatePaintRectangle(paintInvalidationRect);
- }
}
void RenderImage::notifyFinished(Resource* newImage)
« no previous file with comments | « sky/engine/core/rendering/RenderBlock.cpp ('k') | sky/engine/core/rendering/RenderLayer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698