Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: sky/engine/core/frame/FrameView.cpp

Issue 845093002: Delete an assortment of unneeded paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/frame/FrameView.h ('k') | sky/engine/core/html/HTMLCanvasElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/frame/FrameView.cpp
diff --git a/sky/engine/core/frame/FrameView.cpp b/sky/engine/core/frame/FrameView.cpp
index 5db4c925a9a6e45e4ab2c04b24fa9e7788f1aa25..ea8e7e0e92bb35cd111ac07637a32a994b7a75a7 100644
--- a/sky/engine/core/frame/FrameView.cpp
+++ b/sky/engine/core/frame/FrameView.cpp
@@ -407,8 +407,6 @@ void FrameView::invalidateTreeIfNeeded()
RenderView& rootForPaintInvalidation = *renderView();
ASSERT(!rootForPaintInvalidation.needsLayout());
- TRACE_EVENT1("blink", "FrameView::invalidateTree", "root", rootForPaintInvalidation.debugName().ascii().data());
-
PaintInvalidationState rootPaintInvalidationState(rootForPaintInvalidation);
rootForPaintInvalidation.invalidateTreeIfNeeded(rootPaintInvalidationState);
@@ -418,9 +416,6 @@ void FrameView::invalidateTreeIfNeeded()
renderView()->assertSubtreeClearedPaintInvalidationState();
#endif
- if (m_frame->selection().isCaretBoundsDirty())
- m_frame->selection().invalidateCaretRect();
-
lifecycle().advanceTo(DocumentLifecycle::PaintInvalidationClean);
}
@@ -472,20 +467,6 @@ HostWindow* FrameView::hostWindow() const
return &page->chrome();
}
-void FrameView::contentRectangleForPaintInvalidation(const IntRect& r)
-{
- ASSERT(paintInvalidationIsAllowed());
-
- IntRect paintRect = r;
- if (clipsPaintInvalidations() && !paintsEntireContents())
- paintRect.intersect(visibleContentRect());
- if (paintRect.isEmpty())
- return;
-
- if (HostWindow* window = hostWindow())
- window->invalidateContentsAndRootView(contentsToWindow(paintRect));
-}
-
void FrameView::contentsResized()
{
setNeedsLayout();
« no previous file with comments | « sky/engine/core/frame/FrameView.h ('k') | sky/engine/core/html/HTMLCanvasElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698