Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: sky/engine/core/editing/FrameSelection.h

Issue 845093002: Delete an assortment of unneeded paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/editing/Caret.cpp ('k') | sky/engine/core/editing/FrameSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/editing/FrameSelection.h
diff --git a/sky/engine/core/editing/FrameSelection.h b/sky/engine/core/editing/FrameSelection.h
index a518b536e13363c3b7cd8517a763c0e35a478d99..1ecca5e4ef4b58d2e1d944a09680979ba4a18886 100644
--- a/sky/engine/core/editing/FrameSelection.h
+++ b/sky/engine/core/editing/FrameSelection.h
@@ -167,10 +167,8 @@ public:
void updateAppearance(ResetCaretBlinkOption = None);
void setCaretVisible(bool caretIsVisible) { setCaretVisibility(caretIsVisible ? Visible : Hidden); }
- bool isCaretBoundsDirty() const { return m_caretRectDirty; }
void setCaretRectNeedsUpdate();
void scheduleVisualUpdate() const;
- void invalidateCaretRect();
void paintCaret(GraphicsContext*, const LayoutPoint&, const LayoutRect& clipRect);
bool ShouldPaintCaretForTesting() const { return m_shouldPaintCaret; }
@@ -268,14 +266,10 @@ private:
// become null, in which case logical positions == visible positions.
RefPtr<Range> m_logicalRange;
- RefPtr<Node> m_previousCaretNode; // The last node which painted the caret. Retained for clearing the old caret when it moves.
- LayoutRect m_previousCaretRect;
-
RefPtr<EditingStyle> m_typingStyle;
Timer<FrameSelection> m_caretBlinkTimer;
- bool m_caretRectDirty : 1;
bool m_shouldPaintCaret : 1;
bool m_isCaretBlinkingSuspended : 1;
bool m_focused : 1;
« no previous file with comments | « sky/engine/core/editing/Caret.cpp ('k') | sky/engine/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698