Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: sky/engine/core/rendering/RenderView.h

Issue 845093002: Delete an assortment of unneeded paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderParagraph.cpp ('k') | sky/engine/core/rendering/RenderView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2006 Apple Computer, Inc. 3 * Copyright (C) 2006 Apple Computer, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 { 68 {
69 return viewWidth(ExcludeScrollbars); 69 return viewWidth(ExcludeScrollbars);
70 } 70 }
71 int viewLogicalHeight() const; 71 int viewLogicalHeight() const;
72 LayoutUnit viewLogicalHeightForPercentages() const; 72 LayoutUnit viewLogicalHeightForPercentages() const;
73 73
74 FrameView* frameView() const { return m_frameView; } 74 FrameView* frameView() const { return m_frameView; }
75 75
76 virtual void mapRectToPaintInvalidationBacking(const RenderLayerModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalidationState*) const o verride; 76 virtual void mapRectToPaintInvalidationBacking(const RenderLayerModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalidationState*) const o verride;
77 77
78 void invalidatePaintForRectangle(const LayoutRect&) const;
79
80 virtual void paint(PaintInfo&, const LayoutPoint&) override; 78 virtual void paint(PaintInfo&, const LayoutPoint&) override;
81 virtual void paintBoxDecorationBackground(PaintInfo&, const LayoutPoint&) ov erride; 79 virtual void paintBoxDecorationBackground(PaintInfo&, const LayoutPoint&) ov erride;
82 80
83 enum SelectionPaintInvalidationMode { PaintInvalidationNewXOROld, PaintInval idationNewMinusOld, PaintInvalidationNothing }; 81 enum SelectionPaintInvalidationMode { PaintInvalidationNewXOROld, PaintInval idationNewMinusOld, PaintInvalidationNothing };
84 void setSelection(RenderObject* start, int startPos, RenderObject*, int endP os, SelectionPaintInvalidationMode = PaintInvalidationNewXOROld); 82 void setSelection(RenderObject* start, int startPos, RenderObject*, int endP os, SelectionPaintInvalidationMode = PaintInvalidationNewXOROld);
85 void getSelection(RenderObject*& startRenderer, int& startOffset, RenderObje ct*& endRenderer, int& endOffset) const; 83 void getSelection(RenderObject*& startRenderer, int& startOffset, RenderObje ct*& endRenderer, int& endOffset) const;
86 void clearSelection(); 84 void clearSelection();
87 RenderObject* selectionStart() const { return m_selectionStart; } 85 RenderObject* selectionStart() const { return m_selectionStart; }
88 RenderObject* selectionEnd() const { return m_selectionEnd; } 86 RenderObject* selectionEnd() const { return m_selectionEnd; }
89 IntRect selectionBounds(bool clipToVisibleContent = true) const; 87 IntRect selectionBounds(bool clipToVisibleContent = true) const;
(...skipping 19 matching lines...) Expand all
109 // Renderer that paints the root background has background-images which all have background-attachment: fixed. 107 // Renderer that paints the root background has background-images which all have background-attachment: fixed.
110 bool rootBackgroundIsEntirelyFixed() const; 108 bool rootBackgroundIsEntirelyFixed() const;
111 109
112 virtual bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect) const override; 110 virtual bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect) const override;
113 111
114 double layoutViewportWidth() const; 112 double layoutViewportWidth() const;
115 double layoutViewportHeight() const; 113 double layoutViewportHeight() const;
116 114
117 void pushLayoutState(LayoutState&); 115 void pushLayoutState(LayoutState&);
118 void popLayoutState(); 116 void popLayoutState();
119 virtual void invalidateTreeIfNeeded(const PaintInvalidationState&) override final;
120 117
121 void addIFrame(RenderIFrame* iframe); 118 void addIFrame(RenderIFrame* iframe);
122 void removeIFrame(RenderIFrame* iframe); 119 void removeIFrame(RenderIFrame* iframe);
123 void updateIFramesAfterLayout(); 120 void updateIFramesAfterLayout();
124 121
125 private: 122 private:
126 virtual void mapLocalToContainer(const RenderLayerModelObject* paintInvalida tionContainer, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, const PaintInvalidationState* = 0) const override; 123 virtual void mapLocalToContainer(const RenderLayerModelObject* paintInvalida tionContainer, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, const PaintInvalidationState* = 0) const override;
127 virtual const RenderObject* pushMappingToContainer(const RenderLayerModelObj ect* ancestorToStopAt, RenderGeometryMap&) const override; 124 virtual const RenderObject* pushMappingToContainer(const RenderLayerModelObj ect* ancestorToStopAt, RenderGeometryMap&) const override;
128 virtual void mapAbsoluteToLocalPoint(MapCoordinatesFlags, TransformState&) c onst override; 125 virtual void mapAbsoluteToLocalPoint(MapCoordinatesFlags, TransformState&) c onst override;
129 126
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 m_paintInvalidationState->m_cachedOffsetsEnabled = true; 179 m_paintInvalidationState->m_cachedOffsetsEnabled = true;
183 } 180 }
184 private: 181 private:
185 const PaintInvalidationState* m_paintInvalidationState; 182 const PaintInvalidationState* m_paintInvalidationState;
186 bool m_didDisable; 183 bool m_didDisable;
187 }; 184 };
188 185
189 } // namespace blink 186 } // namespace blink
190 187
191 #endif // SKY_ENGINE_CORE_RENDERING_RENDERVIEW_H_ 188 #endif // SKY_ENGINE_CORE_RENDERING_RENDERVIEW_H_
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderParagraph.cpp ('k') | sky/engine/core/rendering/RenderView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698