Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Side by Side Diff: sky/engine/core/rendering/RenderBlock.h

Issue 845093002: Delete an assortment of unneeded paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/html/HTMLCanvasElement.cpp ('k') | sky/engine/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 #endif 197 #endif
198 198
199 // inline-block elements paint all phases atomically. This function ensures that. Certain other elements 199 // inline-block elements paint all phases atomically. This function ensures that. Certain other elements
200 // (flex items) require this behavior as well, and this function exists as a helper for them. 200 // (flex items) require this behavior as well, and this function exists as a helper for them.
201 // It is expected that the caller will call this function independent of the value of paintInfo.phase. 201 // It is expected that the caller will call this function independent of the value of paintInfo.phase.
202 static void paintAsInlineBlock(RenderObject*, PaintInfo&, const LayoutPoint& ); 202 static void paintAsInlineBlock(RenderObject*, PaintInfo&, const LayoutPoint& );
203 203
204 bool recalcChildOverflowAfterStyleChange(); 204 bool recalcChildOverflowAfterStyleChange();
205 bool recalcOverflowAfterStyleChange(); 205 bool recalcOverflowAfterStyleChange();
206 206
207 virtual void invalidateTreeIfNeeded(const PaintInvalidationState&) override;
208
207 protected: 209 protected:
208 virtual void willBeDestroyed() override; 210 virtual void willBeDestroyed() override;
209 211
210 void dirtyForLayoutFromPercentageHeightDescendants(SubtreeLayoutScope&); 212 void dirtyForLayoutFromPercentageHeightDescendants(SubtreeLayoutScope&);
211 213
212 virtual void layout() override; 214 virtual void layout() override;
213 215
214 enum PositionedLayoutBehavior { 216 enum PositionedLayoutBehavior {
215 DefaultLayout, 217 DefaultLayout,
216 ForcedLayoutAfterContainingBlockMoved 218 ForcedLayoutAfterContainingBlockMoved
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 protected: 264 protected:
263 virtual void addOverflowFromChildren(); 265 virtual void addOverflowFromChildren();
264 void addOverflowFromPositionedObjects(); 266 void addOverflowFromPositionedObjects();
265 267
266 virtual void addFocusRingRects(Vector<IntRect>&, const LayoutPoint& addition alOffset, const RenderLayerModelObject* paintContainer = 0) const override; 268 virtual void addFocusRingRects(Vector<IntRect>&, const LayoutPoint& addition alOffset, const RenderLayerModelObject* paintContainer = 0) const override;
267 269
268 void updateBlockChildDirtyBitsBeforeLayout(bool relayoutChildren, RenderBox* ); 270 void updateBlockChildDirtyBitsBeforeLayout(bool relayoutChildren, RenderBox* );
269 271
270 virtual bool isInlineBlock() const override final { return isInline() && isR eplaced(); } 272 virtual bool isInlineBlock() const override final { return isInline() && isR eplaced(); }
271 273
272 virtual void invalidateTreeIfNeeded(const PaintInvalidationState&) override;
273
274 virtual void paintContents(PaintInfo&, const LayoutPoint&); 274 virtual void paintContents(PaintInfo&, const LayoutPoint&);
275 275
276 virtual bool hitTestContents(const HitTestRequest&, HitTestResult&, const Hi tTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTes tAction); 276 virtual bool hitTestContents(const HitTestRequest&, HitTestResult&, const Hi tTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTes tAction);
277 277
278 private: 278 private:
279 virtual RenderObjectChildList* virtualChildren() override final { return chi ldren(); } 279 virtual RenderObjectChildList* virtualChildren() override final { return chi ldren(); }
280 virtual const RenderObjectChildList* virtualChildren() const override final { return children(); } 280 virtual const RenderObjectChildList* virtualChildren() const override final { return children(); }
281 281
282 virtual const char* renderName() const override; 282 virtual const char* renderName() const override;
283 283
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 // member variables out of RenderBlock and into RenderBlockFlow. 352 // member variables out of RenderBlock and into RenderBlockFlow.
353 friend class RenderBlockFlow; 353 friend class RenderBlockFlow;
354 friend class RenderParagraph; 354 friend class RenderParagraph;
355 }; 355 };
356 356
357 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderBlock, isRenderBlock()); 357 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderBlock, isRenderBlock());
358 358
359 } // namespace blink 359 } // namespace blink
360 360
361 #endif // SKY_ENGINE_CORE_RENDERING_RENDERBLOCK_H_ 361 #endif // SKY_ENGINE_CORE_RENDERING_RENDERBLOCK_H_
OLDNEW
« no previous file with comments | « sky/engine/core/html/HTMLCanvasElement.cpp ('k') | sky/engine/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698