Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Unified Diff: chrome/browser/chromeos/file_system_provider/throttled_file_system_unittest.cc

Issue 845083005: [fsp] Simplify aborting logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a comment. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/throttled_file_system_unittest.cc
diff --git a/chrome/browser/chromeos/file_system_provider/throttled_file_system_unittest.cc b/chrome/browser/chromeos/file_system_provider/throttled_file_system_unittest.cc
index 5fff4ba6f2532901524d0e12230425a788f64822..2d4421bf091e362cabc16922e3edd2cad81ee960 100644
--- a/chrome/browser/chromeos/file_system_provider/throttled_file_system_unittest.cc
+++ b/chrome/browser/chromeos/file_system_provider/throttled_file_system_unittest.cc
@@ -156,21 +156,7 @@ TEST_F(FileSystemProviderThrottledFileSystemTest, AbortAfterRun) {
ASSERT_EQ(1u, first_open_log.size());
EXPECT_EQ(base::File::FILE_OK, first_open_log[0].second);
EXPECT_EQ(0u, second_open_log.size());
-
- // The first file is opened, so the opening operation has completed, then
- // aborting it should result in an error. This is tested, as from the queue
- // point of view, the opening task stays in the queue until closing the file.
- StatusLog abort_log;
- abort_callback.Run(base::Bind(&LogStatus, &abort_log));
- base::RunLoop().RunUntilIdle();
-
- ASSERT_EQ(1u, abort_log.size());
- EXPECT_EQ(base::File::FILE_ERROR_INVALID_OPERATION, abort_log[0]);
-
- // Confirm, that the second task is not executed after a invalid abort of the
- // first one.
- EXPECT_EQ(1u, first_open_log.size());
- EXPECT_EQ(0u, second_open_log.size());
}
+
} // namespace file_system_provider
} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/file_system_provider/throttled_file_system.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698