Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 845033002: Re-land "Add a media constraint to enable beamforming" (Closed)

Created:
5 years, 11 months ago by aluebs-chromium
Modified:
5 years, 11 months ago
Reviewers:
ajm, DaleCurtis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land "Add a media constraint to enable beamforming" (patchset #4 id:60001 of https://codereview.chromium.org/833643005/ ) This reverts commit 8fbf60bdf5315ecf8e780ef41b59422e7a3cd0b1. https://codereview.chromium.org/844983002/ Committed: https://crrev.com/24bf8f41ba0d19c84dd3c43441dc95ec0f19308e Cr-Commit-Position: refs/heads/master@{#310892}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M content/renderer/media/media_stream_audio_processor.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor.cc View 4 chunks +27 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
aluebs-chromium
5 years, 11 months ago (2015-01-09 19:56:35 UTC) #2
ajm
lgtm
5 years, 11 months ago (2015-01-09 20:05:18 UTC) #3
DaleCurtis
lgtm
5 years, 11 months ago (2015-01-09 20:18:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845033002/1
5 years, 11 months ago (2015-01-09 22:26:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 23:37:06 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 23:38:09 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/24bf8f41ba0d19c84dd3c43441dc95ec0f19308e
Cr-Commit-Position: refs/heads/master@{#310892}

Powered by Google App Engine
This is Rietveld 408576698