chromecast/browser/metrics/external_metrics.h - Issue 845003002: [chromecast] ExternalMetrics has to destroy itself in file thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/external_metrics.h

Issue 845003002: [chromecast] ExternalMetrics has to destroy itself in file thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/browser/metrics/cast_metrics_service_client.cc ('K') | « chromecast/browser/metrics/cast_metrics_service_client.cc ('k') | chromecast/browser/metrics/external_metrics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/metrics/external_metrics.h

diff --git a/chromecast/browser/metrics/external_metrics.h b/chromecast/browser/metrics/external_metrics.h

index 47c74f3eebe26181148211fa67e87f84d529dee1..2d078cb4a1b5a1e9b2b7d87cd2075389486d7641 100644

--- a/chromecast/browser/metrics/external_metrics.h

+++ b/chromecast/browser/metrics/external_metrics.h

@@ -30,6 +30,9 @@ class ExternalMetrics {

// File thread but are executed in the UI thread.

void Start();

+ // Destroys itself in appropriate thread.

+ void StopAndSelfDestroy();

gunsch 2015/01/10 00:31:46 "SelfDestroy" is sort of strange, why not just "St

gfhuang 2015/01/10 00:58:30 Done.

private:

// The max length of a message (name-value pair, plus header)

static const int kMetricsMessageMaxLength = 1024; // be generous