Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chromecast/browser/metrics/external_metrics.cc

Issue 845003002: [chromecast] ExternalMetrics has to destroy itself in file thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/metrics/external_metrics.cc
diff --git a/chromecast/browser/metrics/external_metrics.cc b/chromecast/browser/metrics/external_metrics.cc
index ce9884cb37dba966e1fae70867ac48ae3181d9a0..4b5f5d92f9713617a5adef2fc2cfcec71286d41c 100644
--- a/chromecast/browser/metrics/external_metrics.cc
+++ b/chromecast/browser/metrics/external_metrics.cc
@@ -58,7 +58,19 @@ ExternalMetrics::ExternalMetrics(
DCHECK(stability_provider);
}
-ExternalMetrics::~ExternalMetrics() {}
+ExternalMetrics::~ExternalMetrics() {
+}
+
+void ExternalMetrics::DestroySelf() {
+ if (!content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE)) {
+ content::BrowserThread::PostTask(
+ content::BrowserThread::FILE,
+ FROM_HERE,
+ base::Bind(&ExternalMetrics::DestroySelf, base::Unretained(this)));
+ return;
+ }
+ delete this;
byungchul 2015/01/09 21:23:24 why not just: content::BrowserThread::DeleteSoon(
gfhuang 2015/01/09 22:30:18 Done.
+}
void ExternalMetrics::Start() {
ScheduleCollector();

Powered by Google App Engine
This is Rietveld 408576698