chromecast/browser/metrics/cast_metrics_service_client.h - Issue 845003002: [chromecast] ExternalMetrics has to destroy itself in file thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.h

Issue 845003002: [chromecast] ExternalMetrics has to destroy itself in file thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/browser/metrics/cast_metrics_service_client.h

diff --git a/chromecast/browser/metrics/cast_metrics_service_client.h b/chromecast/browser/metrics/cast_metrics_service_client.h

index 64c810ba1b9a7b1de08d918a339705bf31ca82f4..af71a1ca1118f5e855344db12cd75f40f001643c 100644

--- a/chromecast/browser/metrics/cast_metrics_service_client.h

+++ b/chromecast/browser/metrics/cast_metrics_service_client.h

@@ -90,7 +90,7 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient {

std::string client_id_;

#if defined(OS_LINUX)

- scoped_ptr<ExternalMetrics> external_metrics_;

+ ExternalMetrics* external_metrics_;

#endif // defined(OS_LINUX)

const scoped_refptr<base::MessageLoopProxy> metrics_service_loop_;

scoped_ptr< ::metrics::MetricsStateManager> metrics_state_manager_;

« no previous file with comments | « no previous file | chromecast/browser/metrics/cast_metrics_service_client.cc » ('j') | no next file with comments »