chromecast/browser/metrics/cast_metrics_service_client.cc - Issue 845003002: [chromecast] ExternalMetrics has to destroy itself in file thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.cc

Issue 845003002: [chromecast] ExternalMetrics has to destroy itself in file thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/browser/metrics/cast_metrics_service_client.cc

diff --git a/chromecast/browser/metrics/cast_metrics_service_client.cc b/chromecast/browser/metrics/cast_metrics_service_client.cc

index 32b4c15130e4bdfcc73da854ac4bc92783b34123..b60bab4727ab748002b6590540faabff98791918 100644

--- a/chromecast/browser/metrics/cast_metrics_service_client.cc

+++ b/chromecast/browser/metrics/cast_metrics_service_client.cc

@@ -250,6 +250,12 @@ void CastMetricsServiceClient::Finalize() {

// Set clean_shutdown bit.

metrics_service_->RecordCompletedSessionEnd();

#endif // !defined(OS_ANDROID)

+ // Stop metrics service cleanly before destructing CastMetricsServiceClient.

+#if defined(OS_LINUX)

+ external_metrics_.release()->DestroySelf();

+#endif // defined(OS_LINUX)

+ metrics_service_.reset();

gunsch 2015/01/09 18:56:19 what's the purpose of this call? won't this happen

gfhuang 2015/01/09 19:10:45 Changed to Stop() to be more clear. and edited CL

}

bool CastMetricsServiceClient::IsReportingEnabled() {

« no previous file with comments | « no previous file | chromecast/browser/metrics/external_metrics.h » ('j') | chromecast/browser/metrics/external_metrics.h » ('J')