[chromecast] ExternalMetrics has to destroy itself in file thread.

chromecast/browser/metrics/cast_metrics_service_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/metrics/cast_metrics_service_client.h"
 
 #include "base/command_line.h"
 #include "base/guid.h"
 #include "base/i18n/rtl.h"
 #include "base/prefs/pref_service.h"
@@ skipping 232 matching lines @@
   external_metrics_.reset(new ExternalMetrics(stability_provider));
   external_metrics_->Start();
 #endif  // defined(OS_LINUX)
 }
 
 void CastMetricsServiceClient::Finalize() {
 #if !defined(OS_ANDROID)
   // Set clean_shutdown bit.
   metrics_service_->RecordCompletedSessionEnd();
 #endif  // !defined(OS_ANDROID)
+
+  // Stop metrics service cleanly before destructing CastMetricsServiceClient.
+#if defined(OS_LINUX)

[lcwu1, 2015/01/10 00:36:39]

In our case, !OS_ANDROID is equal to OS_LINUX, so you should be able to move the
following code to the block above (i.e. below line 251).

[gunsch, 2015/01/10 00:42:23]

I'd prefer not---RecordCompletedSessionEnd is actually declared with
!OS_ANDROID, and ExternalMetrics is guarded with OS_LINUX due to Linux-specific
dependencies.

I agree that for us those two are equivalent, but it seems like an unnecessary
assumption to make.

[gfhuang, 2015/01/10 00:58:30]

Acknowledged.

+  external_metrics_.release()->StopAndSelfDestroy();

[gunsch, 2015/01/10 00:31:46]

Thought: this mechanic is sort of strange. I think it would make more sense to
do the following:

1) Make ~ExternalMetrics private (since no one should be calling it)
2) Make CastMetricsServiceClient have a ExternalMetrics* instead of a
scoped_ptr<ExternalMetrics>

what do you think?

[gfhuang, 2015/01/10 00:58:30]

Done.

[gfhuang, 2015/01/10 01:17:30]

Note that I have to revert back to use PostTask instead of DeleteSoon though,
since dtor is private now.

+#endif  // defined(OS_LINUX)
+  metrics_service_->Stop();
 }
 
 bool CastMetricsServiceClient::IsReportingEnabled() {
   return PlatformIsReportingEnabled(cast_service_);
 }
 
 }  // namespace metrics
 }  // namespace chromecast