Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: chromecast/browser/metrics/external_metrics.cc

Issue 845003002: [chromecast] ExternalMetrics has to destroy itself in file thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromecast/browser/metrics/external_metrics.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/browser/metrics/external_metrics.h" 5 #include "chromecast/browser/metrics/external_metrics.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 const char kEventsFilePath[] = "/data/share/chrome/metrics/uma-events"; 51 const char kEventsFilePath[] = "/data/share/chrome/metrics/uma-events";
52 52
53 ExternalMetrics::ExternalMetrics( 53 ExternalMetrics::ExternalMetrics(
54 CastStabilityMetricsProvider* stability_provider) 54 CastStabilityMetricsProvider* stability_provider)
55 : stability_provider_(stability_provider), 55 : stability_provider_(stability_provider),
56 uma_events_file_(kEventsFilePath), 56 uma_events_file_(kEventsFilePath),
57 weak_factory_(this) { 57 weak_factory_(this) {
58 DCHECK(stability_provider); 58 DCHECK(stability_provider);
59 } 59 }
60 60
61 ExternalMetrics::~ExternalMetrics() {} 61 ExternalMetrics::~ExternalMetrics() {
62 }
63
64 void ExternalMetrics::StopAndDestroy() {
65 content::BrowserThread::DeleteSoon(
66 content::BrowserThread::FILE, FROM_HERE, this);
67 }
62 68
63 void ExternalMetrics::Start() { 69 void ExternalMetrics::Start() {
64 ScheduleCollector(); 70 ScheduleCollector();
65 } 71 }
66 72
67 void ExternalMetrics::RecordCrash(const std::string& crash_kind) { 73 void ExternalMetrics::RecordCrash(const std::string& crash_kind) {
68 content::BrowserThread::PostTask( 74 content::BrowserThread::PostTask(
69 content::BrowserThread::UI, FROM_HERE, 75 content::BrowserThread::UI, FROM_HERE,
70 base::Bind(&CastStabilityMetricsProvider::LogExternalCrash, 76 base::Bind(&CastStabilityMetricsProvider::LogExternalCrash,
71 base::Unretained(stability_provider_), 77 base::Unretained(stability_provider_),
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 content::BrowserThread::FILE, 142 content::BrowserThread::FILE,
137 FROM_HERE, 143 FROM_HERE,
138 base::Bind(&ExternalMetrics::CollectEventsAndReschedule, 144 base::Bind(&ExternalMetrics::CollectEventsAndReschedule,
139 weak_factory_.GetWeakPtr()), 145 weak_factory_.GetWeakPtr()),
140 base::TimeDelta::FromSeconds(kExternalMetricsCollectionIntervalSeconds)); 146 base::TimeDelta::FromSeconds(kExternalMetricsCollectionIntervalSeconds));
141 DCHECK(result); 147 DCHECK(result);
142 } 148 }
143 149
144 } // namespace metrics 150 } // namespace metrics
145 } // namespace chromecast 151 } // namespace chromecast
OLDNEW
« no previous file with comments | « chromecast/browser/metrics/external_metrics.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698