[chromecast] ExternalMetrics has to destroy itself in file thread.

chromecast/browser/metrics/external_metrics.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/metrics/external_metrics.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
@@ skipping 40 matching lines @@
 const char kEventsFilePath[] = "/data/share/chrome/metrics/uma-events";
 
 ExternalMetrics::ExternalMetrics(
     CastStabilityMetricsProvider* stability_provider)
     : stability_provider_(stability_provider),
       uma_events_file_(kEventsFilePath),
       weak_factory_(this) {
   DCHECK(stability_provider);
 }
 
-ExternalMetrics::~ExternalMetrics() {}
+ExternalMetrics::~ExternalMetrics() {
+}
+
+void ExternalMetrics::DestroySelf() {
+  if (!content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE)) {

[gunsch, 2015/01/09 18:56:19]

Why does it need to be destroyed on the file thread? Is it because of the weak
pointer factory?

[gfhuang, 2015/01/09 19:10:45]

Yes

+    content::BrowserThread::PostTask(
+        content::BrowserThread::FILE,
+        FROM_HERE,
+        base::Bind(&ExternalMetrics::DestroySelf, base::Unretained(this)));
+    return;
+  }
+  delete this;
+}
 
 void ExternalMetrics::Start() {
   ScheduleCollector();
 }
 
 void ExternalMetrics::RecordCrash(const std::string& crash_kind) {
   content::BrowserThread::PostTask(
       content::BrowserThread::UI, FROM_HERE,
       base::Bind(&CastStabilityMetricsProvider::LogExternalCrash,
                  base::Unretained(stability_provider_),
@@ skipping 64 matching lines @@
       content::BrowserThread::FILE,
       FROM_HERE,
       base::Bind(&ExternalMetrics::CollectEventsAndReschedule,
                  weak_factory_.GetWeakPtr()),
       base::TimeDelta::FromSeconds(kExternalMetricsCollectionIntervalSeconds));
   DCHECK(result);
 }
 
 }  // namespace metrics
 }  // namespace chromecast