Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 844983004: Support transitioning between platform scrolling and JS pinching (Closed)

Created:
5 years, 11 months ago by jdduke (slow)
Modified:
5 years, 11 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, darin-cc_chromium.org, jdduke+watch_chromium.org, jam, lanwei
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support transitioning between platform scrolling and JS pinching While a scroll gesture sequence is active, dispatch secondary touchstart events synchronously, allowing them to be preventDefault'ed by the page. This affords sites the opportunity to customize pinch/multitouch without completely sacrificing the benefits of platform (and threaded) scrolling. Note that even after a page preventDefaults a secondary touchstart, platform scrolling can resume if the handler stops preventDefault'ing touchmove events. BUG=447738 Committed: https://crrev.com/6f12081771bb3f89e3d2d6b6e5e91a16c29ab4f6 Cr-Commit-Position: refs/heads/master@{#311737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -5 lines) Patch
M content/browser/renderer_host/input/touch_event_queue.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 2 chunks +62 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jdduke (slow)
rbyers@: Could you take a look? Tested on http://jsbin.com/xoqapi/1/quiet (I know, nothing fancy), and you ...
5 years, 11 months ago (2015-01-15 19:25:57 UTC) #2
Rick Byers
Nice, lgtm!
5 years, 11 months ago (2015-01-15 20:50:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844983004/1
5 years, 11 months ago (2015-01-15 20:52:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 21:17:03 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 21:19:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f12081771bb3f89e3d2d6b6e5e91a16c29ab4f6
Cr-Commit-Position: refs/heads/master@{#311737}

Powered by Google App Engine
This is Rietveld 408576698