Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 844983002: Revert of Add a media constraint to enable beamforming. (Closed)

Created:
5 years, 11 months ago by scottmg
Modified:
5 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a media constraint to enable beamforming. (patchset #4 id:60001 of https://codereview.chromium.org/833643005/) Reason for revert: I had to revert the WebRTC roll https://codereview.chromium.org/839173004/ And so now this doesn't compile so I'm going to revert it also. Sorry for the hassle, hopefully it's an easy reland. Original issue's description: > Add a media constraint to enable beamforming. > > Check the ChromeOS model to pass down the correct microphone array geometry. > > BUG=405270 > > Committed: https://crrev.com/0201ae167ae81ba069f4f9a5498d5f95694edc8d > Cr-Commit-Position: refs/heads/master@{#310777} TBR=ajm@chromium.org,dalecurtis@chromium.org,aluebs@chromium.org NOTREECHECKS=true NOTRY=true BUG=405270 Committed: https://crrev.com/8fbf60bdf5315ecf8e780ef41b59422e7a3cd0b1 Cr-Commit-Position: refs/heads/master@{#310804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -31 lines) Patch
M content/renderer/media/media_stream_audio_processor.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_processor.cc View 4 chunks +1 line, -27 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
Created Revert of Add a media constraint to enable beamforming.
5 years, 11 months ago (2015-01-09 18:40:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844983002/1
5 years, 11 months ago (2015-01-09 18:41:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 18:43:19 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8fbf60bdf5315ecf8e780ef41b59422e7a3cd0b1 Cr-Commit-Position: refs/heads/master@{#310804}
5 years, 11 months ago (2015-01-09 18:44:59 UTC) #4
ajm
lgtm Arg! Thanks for the details Scott.
5 years, 11 months ago (2015-01-09 18:50:40 UTC) #5
aluebs-chromium
5 years, 11 months ago (2015-01-09 18:59:43 UTC) #6
Message was sent while issue was closed.
lgtm
Too bad the WebRTC roll had to be reverted. We were depending on that.

Powered by Google App Engine
This is Rietveld 408576698