Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 844913002: [ServiceWorker] Refactor the codes for releasing the resources for streaming. (Closed)

Created:
5 years, 11 months ago by horo
Modified:
5 years, 11 months ago
Reviewers:
michaeln
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Refactor the codes for releasing the resources for streaming in ServiceWorkerURLRequestJob. As michaeln@ mentioned in https://codereview.chromium.org/832813002/, Kill() may not be called and provider_host_ may be deleted before Kill() is called. So this change - adds streaming_version_ property to ServiceWorkerURLRequestJob. - adds ClearStream() method to releases the resources for streaming. - calls ClearStream() from both Kill() and the destructor. BUG=445775 Committed: https://crrev.com/e9520537ba1d85df2273c80de2c50aea0ab8ee72 Cr-Commit-Position: refs/heads/master@{#310944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M content/browser/service_worker/service_worker_url_request_job.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 4 chunks +22 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
horo
michaeln@ Could you please review this?
5 years, 11 months ago (2015-01-09 04:58:43 UTC) #2
michaeln
lgtm... thnx!
5 years, 11 months ago (2015-01-09 22:14:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844913002/1
5 years, 11 months ago (2015-01-10 02:00:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-10 02:40:09 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-10 02:40:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9520537ba1d85df2273c80de2c50aea0ab8ee72
Cr-Commit-Position: refs/heads/master@{#310944}

Powered by Google App Engine
This is Rietveld 408576698