Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 844903003: Gallery: Add timeout for Gallery relunch. (Closed)

Created:
5 years, 11 months ago by hirono
Modified:
5 years, 11 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: Add timeout for Gallery relunch. This is workaround for crbug.com/442217. BUG=442217 TEST=None Committed: https://crrev.com/ffb643afc26c5259015c0d4d2fc1254cffd0bc78 Cr-Commit-Position: refs/heads/master@{#310735}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/closure_compiler/externs/file_manager_private.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
hirono
PTAL? Thanks! Note that 0ms and 300ms are not enough to avoid the bug.
5 years, 11 months ago (2015-01-09 07:07:00 UTC) #2
yawano
lgtm. Thank you!
5 years, 11 months ago (2015-01-09 07:21:21 UTC) #3
hirono
On 2015/01/09 07:21:21, yawano wrote: > lgtm. Thank you! Checked on daisy_spring (yoshi) and it ...
5 years, 11 months ago (2015-01-09 07:49:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844903003/1
5 years, 11 months ago (2015-01-09 07:50:16 UTC) #6
yawano
On 2015/01/09 07:49:13, hirono wrote: > On 2015/01/09 07:21:21, yawano wrote: > > lgtm. Thank ...
5 years, 11 months ago (2015-01-09 07:51:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 08:10:46 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 08:11:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffb643afc26c5259015c0d4d2fc1254cffd0bc78
Cr-Commit-Position: refs/heads/master@{#310735}

Powered by Google App Engine
This is Rietveld 408576698