Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: ui/app_list/views/apps_grid_view.cc

Issue 844883002: App list: Fixed rendering issues upon opening the window in RTL mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rewrite calamity TODO in the other file. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/app_list/views/contents_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/views/apps_grid_view.cc
diff --git a/ui/app_list/views/apps_grid_view.cc b/ui/app_list/views/apps_grid_view.cc
index 84a31ab4d57c24b298ad46e22abcdd0824f40e02..6e3c9c0a80df3a09b7ff8fff9cd92bf1a49d76e5 100644
--- a/ui/app_list/views/apps_grid_view.cc
+++ b/ui/app_list/views/apps_grid_view.cc
@@ -1167,8 +1167,9 @@ void AppsGridView::MoveSelected(int page_delta,
}
void AppsGridView::CalculateIdealBounds() {
- // TODO(calamity): This fixes http://crbug.com/422604 on ChromeOS but it's
- // unclear why. This should be investigated to fix the issue on Linux Ash.
+ // TODO(mgiuca): This is a work-around for http://crbug.com/422604. See
+ // comment in ContentsView::Layout for details. This should be removed once
+ // http://crbug.com/446407 is resolved.
if (GetContentsBounds().IsEmpty())
return;
« no previous file with comments | « no previous file | ui/app_list/views/contents_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698