Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 844883002: App list: Fixed rendering issues upon opening the window in RTL mode. (Closed)

Created:
5 years, 11 months ago by Matt Giuca
Modified:
5 years, 11 months ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, calamity
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

App list: Fixed rendering issues upon opening the window in RTL mode. This fixes two related bugs, one in the classic and one in the experimental launcher in right-to-left languages. The classic launcher would display a blank page upon opening the window; the experimental launcher would display the start page layered on top of the apps grid. The root cause of both bugs is http://crbug.com/446407; this is a quick fix for merging back to M40 where this regressed. BUG=441962 BUG=446978 Committed: https://crrev.com/c4a4b2c0f631c25626b5c9a42ed569d4cd77143f Cr-Commit-Position: refs/heads/master@{#310682}

Patch Set 1 #

Patch Set 2 : Rewrite calamity TODO in the other file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M ui/app_list/views/apps_grid_view.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ui/app_list/views/contents_view.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Matt Giuca
This fixes both http://crbug.com/446978 (classic) and http://crbug.com/441962 (experimental), by using the same work-around as calamity ...
5 years, 11 months ago (2015-01-09 00:46:23 UTC) #2
tapted
Nice sleuthing! lgtm
5 years, 11 months ago (2015-01-09 00:55:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844883002/20001
5 years, 11 months ago (2015-01-09 01:09:58 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-09 02:40:03 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 02:40:47 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4a4b2c0f631c25626b5c9a42ed569d4cd77143f
Cr-Commit-Position: refs/heads/master@{#310682}

Powered by Google App Engine
This is Rietveld 408576698