sky/engine/core/css/resolver/StyleResolver.cpp - Issue 844873002: Simplify the style sharing list code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/css/resolver/StyleResolver.cpp

Issue 844873002: Simplify the style sharing list code. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/css/resolver/StyleResolver.cpp

diff --git a/sky/engine/core/css/resolver/StyleResolver.cpp b/sky/engine/core/css/resolver/StyleResolver.cpp

index d78bb38fed1c5b639ca9cf0b86db1cd71f867d39..5a60e8f3f01f4f183367ca61a69396394d3c4dac 100644

--- a/sky/engine/core/css/resolver/StyleResolver.cpp

+++ b/sky/engine/core/css/resolver/StyleResolver.cpp

@@ -126,7 +126,6 @@ StyleResolver::StyleResolver(Document& document)

: m_document(document)

, m_printMediaType(false)

, m_styleResourceLoader(document.fetcher())

- , m_styleSharingDepth(0)

, m_styleResolverStatsSequence(0)

, m_accessCount(0)

{

@@ -217,22 +216,9 @@ void StyleResolver::addToStyleSharingList(Element& element)

list.prepend(&element);

}

-StyleSharingList& StyleResolver::styleSharingList()

- m_styleSharingLists.resize(styleSharingMaxDepth);

- // We never put things at depth 0 into the list since that's only the <html> element

- // and it has no siblings or cousins to share with.

- unsigned depth = std::max(std::min(m_styleSharingDepth, styleSharingMaxDepth), 1u) - 1u;

- if (!m_styleSharingLists[depth])

- m_styleSharingLists[depth] = adoptPtr(new StyleSharingList);

- return *m_styleSharingLists[depth];

void StyleResolver::clearStyleSharingList()

{

- m_styleSharingLists.resize(0);

+ m_styleSharingList.clear();

}

StyleResolver::~StyleResolver()

« no previous file with comments | « sky/engine/core/css/resolver/StyleResolver.h ('k') | sky/engine/core/dom/Document.cpp » ('j') | no next file with comments »