Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: tools/perf/benchmarks/dromaeo.py

Issue 84483002: [telemetry] Fix types and type checks of numeric results. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tools/perf/metrics/media.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os 5 import os
6 6
7 from telemetry import test 7 from telemetry import test
8 from telemetry.core import util 8 from telemetry.core import util
9 from telemetry.page import page_measurement 9 from telemetry.page import page_measurement
10 from telemetry.page import page_set 10 from telemetry.page import page_set
(...skipping 12 matching lines...) Expand all
23 chars = [' ', '-', '/', '(', ')', '*'] 23 chars = [' ', '-', '/', '(', ')', '*']
24 for c in chars: 24 for c in chars:
25 k = k.replace(c, '_') 25 k = k.replace(c, '_')
26 return k 26 return k
27 27
28 suffix = page.url[page.url.index('?') + 1 : page.url.index('&')] 28 suffix = page.url[page.url.index('?') + 1 : page.url.index('&')]
29 for k, v in score.iteritems(): 29 for k, v in score.iteritems():
30 data_type = 'unimportant' 30 data_type = 'unimportant'
31 if k == suffix: 31 if k == suffix:
32 data_type = 'default' 32 data_type = 'default'
33 results.Add(Escape(k), 'runs/s', v, data_type=data_type) 33 results.Add(Escape(k), 'runs/s', float(v), data_type=data_type)
34 34
35 35
36 class _DromaeoBenchmark(test.Test): 36 class _DromaeoBenchmark(test.Test):
37 """A base class for Dromaeo benchmarks.""" 37 """A base class for Dromaeo benchmarks."""
38 test = _DromaeoMeasurement 38 test = _DromaeoMeasurement
39 39
40 def CreatePageSet(self, options): 40 def CreatePageSet(self, options):
41 """Makes a PageSet for Dromaeo benchmarks.""" 41 """Makes a PageSet for Dromaeo benchmarks."""
42 # Subclasses are expected to define a class member called query_param. 42 # Subclasses are expected to define a class member called query_param.
43 if not hasattr(self, 'query_param'): 43 if not hasattr(self, 'query_param'):
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 """Dromaeo JSLib traverse jquery JavaScript benchmark""" 131 """Dromaeo JSLib traverse jquery JavaScript benchmark"""
132 tag = 'jslibtraversejquery' 132 tag = 'jslibtraversejquery'
133 query_param = 'jslib-traverse-jquery' 133 query_param = 'jslib-traverse-jquery'
134 134
135 135
136 class DromaeoJslibTraversePrototype(_DromaeoBenchmark): 136 class DromaeoJslibTraversePrototype(_DromaeoBenchmark):
137 """Dromaeo JSLib traverse prototype JavaScript benchmark""" 137 """Dromaeo JSLib traverse prototype JavaScript benchmark"""
138 tag = 'jslibtraverseprototype' 138 tag = 'jslibtraverseprototype'
139 query_param = 'jslib-traverse-prototype' 139 query_param = 'jslib-traverse-prototype'
140 140
OLDNEW
« no previous file with comments | « no previous file | tools/perf/metrics/media.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698