ash/wm/panels/panel_layout_manager.h - Issue 844763006: Change overview mode to so that docked panel windows are not grouped together.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/panels/panel_layout_manager.h

Issue 844763006: Change overview mode to so that docked panel windows are not grouped together. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved restore window animation out of the ScopedTransformOverviewWindow destructor. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/overview/window_selector_item.cc ('K') | « ash/wm/overview/window_selector_unittest.cc ('k') | ash/wm/panels/panel_layout_manager.cc » ('j') | ash/wm/panels/panel_layout_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/panels/panel_layout_manager.h

diff --git a/ash/wm/panels/panel_layout_manager.h b/ash/wm/panels/panel_layout_manager.h

index dc258da71bdfbf57cc73ba3683405e29a57f6094..635c6a62a78b0e4512282d767472793d7e9e116c 100644

--- a/ash/wm/panels/panel_layout_manager.h

+++ b/ash/wm/panels/panel_layout_manager.h

@@ -95,6 +95,8 @@ class ASH_EXPORT PanelLayoutManager

void OnShelfIconPositionsChanged() override;

// Overridden from ShellObserver

+ void OnOverviewModeStarting() override;

+ void OnOverviewModeEnding() override;

void OnShelfAlignmentChanged(aura::Window* root_window) override;

// Overridden from aura::WindowObserver

@@ -191,6 +193,9 @@ class ASH_EXPORT PanelLayoutManager

aura::Window* last_active_panel_;

base::WeakPtrFactory<PanelLayoutManager> weak_factory_;

+ // Track whether overview mode is active. Used to suppress layouts when it is.

+ bool overview_mode_active_;

DISALLOW_COPY_AND_ASSIGN(PanelLayoutManager);

};