ash/shell.cc - Issue 844763006: Change overview mode to so that docked panel windows are not grouped together.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell.cc

Issue 844763006: Change overview mode to so that docked panel windows are not grouped together. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved restore window animation out of the ScopedTransformOverviewWindow destructor. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shell.cc

diff --git a/ash/shell.cc b/ash/shell.cc

index 9062d81afef808035530897d9c50fbcfab07187f..a40d3b55bb5f4dc48d71a5a6c2281fd51399119c 100644

--- a/ash/shell.cc

+++ b/ash/shell.cc

@@ -745,6 +745,12 @@ Shell::~Shell() {

resize_shadow_controller_.reset();

window_cycle_controller_.reset();

+ // Need to ensure that the WindowSelector is properly destroyed and cleaned up

+ // prior to deleting the |window_selector_controller_|. See

+ // WindowSelectorController documentation for more info.

+ if (window_selector_controller_->IsSelecting())

+ window_selector_controller_->ToggleOverview();

jonross 2015/01/15 19:39:42 I'd like to avoid this if possible. Can we check w

bruthig 2015/01/16 19:54:43 Done.

window_selector_controller_.reset();

mru_window_tracker_.reset();

« no previous file with comments | « ash/ash.gyp ('k') | ash/wm/overview/scoped_transform_overview_window.h » ('j') | ash/wm/overview/window_selector.h » ('J')