Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1571)

Unified Diff: ash/shell.cc

Issue 844763006: Change overview mode to so that docked panel windows are not grouped together. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Polished after a self-review. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shell.cc
diff --git a/ash/shell.cc b/ash/shell.cc
index 9062d81afef808035530897d9c50fbcfab07187f..856f3b22fa59aa2cd29933eb168b7656e2eb129e 100644
--- a/ash/shell.cc
+++ b/ash/shell.cc
@@ -745,6 +745,12 @@ Shell::~Shell() {
resize_shadow_controller_.reset();
window_cycle_controller_.reset();
+
+ // Need to ensure that the WindowSelector is properly destroyed and cleaned up
+ // prior to deleting the |window_selector_controller_|. See
+ // WindowSelectorController docmentation for more info.
jonross 2015/01/15 13:37:47 nit: documentation
bruthig 2015/01/15 18:27:24 Done.
+ if (window_selector_controller_->IsSelecting())
+ window_selector_controller_->ToggleOverview();
window_selector_controller_.reset();
mru_window_tracker_.reset();

Powered by Google App Engine
This is Rietveld 408576698