ash/wm/maximize_mode/maximize_mode_window_manager.cc - Issue 844763006: Change overview mode to so that docked panel windows are not grouped together.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/maximize_mode/maximize_mode_window_manager.cc

Issue 844763006: Change overview mode to so that docked panel windows are not grouped together. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed stale pointer in ScopedTransformOverviewWindow. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/wm/maximize_mode/maximize_mode_window_manager.cc

diff --git a/ash/wm/maximize_mode/maximize_mode_window_manager.cc b/ash/wm/maximize_mode/maximize_mode_window_manager.cc

index 7506bee8731febf54e8c6de7142ec6f4b9babb9a..953ae14c19dacf32e9bec6d117d5e34bbf54d935 100644

--- a/ash/wm/maximize_mode/maximize_mode_window_manager.cc

+++ b/ash/wm/maximize_mode/maximize_mode_window_manager.cc

@@ -85,7 +85,7 @@ void MaximizeModeWindowManager::OnOverviewModeStarting() {

backdrops_hidden_ = true;

}

-void MaximizeModeWindowManager::OnOverviewModeEnding() {

+void MaximizeModeWindowManager::OnOverviewModeEnded() {

if (!backdrops_hidden_)

return;

« no previous file with comments | « ash/wm/maximize_mode/maximize_mode_window_manager.h ('k') | ash/wm/overview/scoped_transform_overview_window.h » ('j') | no next file with comments »