Change overview mode to so that docked panel windows are not grouped together.

ash/wm/overview/window_selector.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_OVERVIEW_WINDOW_SELECTOR_H_
 #define ASH_WM_OVERVIEW_WINDOW_SELECTOR_H_
 
 #include <set>
 #include <vector>
 
@@ skipping 48 matching lines @@
   enum Direction {
     LEFT,
     UP,
     RIGHT,
     DOWN
   };
 
   typedef std::vector<aura::Window*> WindowList;
   typedef ScopedVector<WindowSelectorItem> WindowSelectorItemList;
 
-  WindowSelector(const WindowList& windows,
-                 WindowSelectorDelegate* delegate);
+  explicit WindowSelector(WindowSelectorDelegate* delegate);
   ~WindowSelector() override;
 
+  // NOTE: The work done in Init() and Shutdown() is not done in the

[jonross, 2015/01/15 19:39:42]

Could this information be worked into the existing docs for init/shutdown?

[bruthig, 2015/01/16 19:54:43]

Moved these 'implementation' specific comments to the cc file.

Done.

+  // constructor/destructor because it may cause other, unrelated classes,
+  // (ie PanelLayoutManager) to make indirect calls to
+  // restoring_minimized_windows() on a partially constructed/destructed object.
+
+  // Initialize with the windows that can be selected.
+  void Init(const WindowList& windows);
+  // Perform cleanup that cannot be done in the destructor.

[jonross, 2015/01/15 19:39:42]

nit: space between non-override methods that have comments

[bruthig, 2015/01/16 19:54:43]

Done.

+  void Shutdown();
+
   // Cancels window selection.
   void CancelSelection();
 
   // Called when the last window selector item from a grid is deleted.
   void OnGridEmpty(WindowGrid* grid);
 
+  bool restoring_minimized_windows() const {
+    return restoring_minimized_windows_;
+  }
+
   // gfx::DisplayObserver:
   void OnDisplayAdded(const gfx::Display& display) override;
   void OnDisplayRemoved(const gfx::Display& display) override;
   void OnDisplayMetricsChanged(const gfx::Display& display,
                                uint32_t metrics) override;
 
   // aura::WindowObserver:
   void OnWindowAdded(aura::Window* new_window) override;
   void OnWindowDestroying(aura::Window* window) override;
 
@@ skipping 73 matching lines @@
   // such as enter key to select.
   scoped_ptr<views::Widget> text_filter_widget_;
 
   // The current length of the string entered into the text filtering textfield.
   size_t text_filter_string_length_;
 
   // The number of times the text filtering textfield has been cleared of text
   // during this overview mode session.
   size_t num_times_textfield_cleared_;
 
+  // Tracks whether minimized windows are currently being restored for overview
+  // mode.
+  bool restoring_minimized_windows_;
+
   DISALLOW_COPY_AND_ASSIGN(WindowSelector);
 };
 
 }  // namespace ash
 
 #endif  // ASH_WM_OVERVIEW_WINDOW_SELECTOR_H_