Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: pkg/compiler/lib/src/warnings.dart

Issue 844723004: dart2js: Fix small typo in warnings comments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 const DONT_KNOW_HOW_TO_FIX = "Computer says no!"; 7 const DONT_KNOW_HOW_TO_FIX = "Computer says no!";
8 8
9 /** 9 /**
10 * The messages in this file should meet the following guide lines: 10 * The messages in this file should meet the following guide lines:
(...skipping 22 matching lines...) Expand all
33 * 6. Prefer contractions when they are in common use, for example, prefer 33 * 6. Prefer contractions when they are in common use, for example, prefer
34 * "can't" over "cannot". Using "cannot", "must not", "shall not", etc. is 34 * "can't" over "cannot". Using "cannot", "must not", "shall not", etc. is
35 * off-putting to people new to programming. 35 * off-putting to people new to programming.
36 * 36 *
37 * 7. Use common terminology, preferably from the Dart Language 37 * 7. Use common terminology, preferably from the Dart Language
38 * Specification. This increases the user's chance of finding a good 38 * Specification. This increases the user's chance of finding a good
39 * explanation on the web. 39 * explanation on the web.
40 * 40 *
41 * 8. Do not try to be cute or funny. It is extremely frustrating to work on a 41 * 8. Do not try to be cute or funny. It is extremely frustrating to work on a
42 * product that crashes with a "tongue-in-cheek" message, especially if you did 42 * product that crashes with a "tongue-in-cheek" message, especially if you did
43 * not want to use this product to begin with with. 43 * not want to use this product to begin with.
44 * 44 *
45 * 9. Do not lie, that is, do not write error messages containing phrases like 45 * 9. Do not lie, that is, do not write error messages containing phrases like
46 * "can't happen". If the user ever saw this message, it would be a 46 * "can't happen". If the user ever saw this message, it would be a
47 * lie. Prefer messages like: "Internal error: This function should not be 47 * lie. Prefer messages like: "Internal error: This function should not be
48 * called when 'x' is null.". 48 * called when 'x' is null.".
49 * 49 *
50 * 10. Prefer to not use imperative tone. That is, the message should not sound 50 * 10. Prefer to not use imperative tone. That is, the message should not sound
51 * accusing or like it is ordering the user around. The computer should 51 * accusing or like it is ordering the user around. The computer should
52 * describe the problem, not criticize for violating the specification. 52 * describe the problem, not criticize for violating the specification.
53 * 53 *
(...skipping 2401 matching lines...) Expand 10 before | Expand all | Expand 10 after
2455 static String convertToString(value) { 2455 static String convertToString(value) {
2456 if (value is ErrorToken) { 2456 if (value is ErrorToken) {
2457 // Shouldn't happen. 2457 // Shouldn't happen.
2458 return value.assertionMessage; 2458 return value.assertionMessage;
2459 } else if (value is Token) { 2459 } else if (value is Token) {
2460 value = value.value; 2460 value = value.value;
2461 } 2461 }
2462 return '$value'; 2462 return '$value';
2463 } 2463 }
2464 } 2464 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698