Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 844643005: Fix few compilation errors on Windows in media/ during Windows GN build. (Closed)

Created:
5 years, 11 months ago by Slava Chigrin
Modified:
3 years, 3 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, qsr+mojo_chromium.org, imcheng+watch_chromium.org, Aaron Boodman, hguihot+watch_chromium.org, jasonroberts+watch_google.com, viettrungluu+watch_chromium.org, avayvod+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, pwestin+watch_google.com, feature-media-reviews_chromium.org, darin (slow to review), miu+watch_chromium.org, ben+mojo_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix few compilation errors on Windows in media/ during Windows GN build. Committed: https://crrev.com/2a25593b2d7f5c5f963f6c6dfc33f52a0913c077 Cr-Commit-Position: refs/heads/master@{#312092}

Patch Set 1 #

Patch Set 2 : Fix Linux build. #

Total comments: 5

Patch Set 3 : Add comment. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M media/audio/BUILD.gn View 1 2 chunks +4 lines, -2 lines 2 comments Download
M media/cast/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_cdm.h View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M media/mojo/services/mojo_cdm.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M media/mojo/services/mojo_media_application.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Slava Chigrin
https://codereview.chromium.org/844643005/diff/20001/media/audio/BUILD.gn File media/audio/BUILD.gn (left): https://codereview.chromium.org/844643005/diff/20001/media/audio/BUILD.gn#oldcode269 media/audio/BUILD.gn:269: "audio_low_latency_input_output_unittest.cc", Same as in GYP, see https://code.google.com/p/chromium/codesearch#chromium/src/media/media.gyp&q=audio_low_latency_input_output_unittest.cc&sq=package:chromium&l=1347&type=cs https://codereview.chromium.org/844643005/diff/20001/media/mojo/services/mojo_cdm.h File ...
5 years, 11 months ago (2015-01-18 22:12:26 UTC) #2
xhwang
media lgtm % nit, thanks! https://codereview.chromium.org/844643005/diff/20001/media/cast/BUILD.gn File media/cast/BUILD.gn (right): https://codereview.chromium.org/844643005/diff/20001/media/cast/BUILD.gn#newcode1 media/cast/BUILD.gn:1: # Copyright 2014 The ...
5 years, 11 months ago (2015-01-19 02:59:51 UTC) #3
miu
media/cast lgtm
5 years, 11 months ago (2015-01-19 05:54:43 UTC) #5
Slava Chigrin
Done, thank everybody for review!
5 years, 11 months ago (2015-01-19 09:11:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844643005/40001
5 years, 11 months ago (2015-01-19 09:32:33 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-19 10:30:00 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/2a25593b2d7f5c5f963f6c6dfc33f52a0913c077 Cr-Commit-Position: refs/heads/master@{#312092}
5 years, 11 months ago (2015-01-19 10:30:56 UTC) #10
tommi (sloooow) - chröme
https://codereview.chromium.org/844643005/diff/40001/media/audio/BUILD.gn File media/audio/BUILD.gn (right): https://codereview.chromium.org/844643005/diff/40001/media/audio/BUILD.gn#newcode331 media/audio/BUILD.gn:331: "audio_low_latency_input_output_unittest.cc", I'm trying to figure out why this file ...
3 years, 3 months ago (2017-09-04 17:14:27 UTC) #12
Slava Chigrin
https://codereview.chromium.org/844643005/diff/40001/media/audio/BUILD.gn File media/audio/BUILD.gn (right): https://codereview.chromium.org/844643005/diff/40001/media/audio/BUILD.gn#newcode331 media/audio/BUILD.gn:331: "audio_low_latency_input_output_unittest.cc", On 2017/09/04 17:14:27, tommi (sloooow) - chröme wrote: ...
3 years, 3 months ago (2017-09-05 08:25:11 UTC) #13
tommi (sloooow) - chröme
3 years, 3 months ago (2017-09-05 08:42:57 UTC) #14
Message was sent while issue was closed. 
On 2017/09/05 08:25:11, Slava Chigrin wrote:
> https://codereview.chromium.org/844643005/diff/40001/media/audio/BUILD.gn
> File media/audio/BUILD.gn (right):
> 
>
https://codereview.chromium.org/844643005/diff/40001/media/audio/BUILD.gn#new...
> media/audio/BUILD.gn:331: "audio_low_latency_input_output_unittest.cc",
> On 2017/09/04 17:14:27, tommi (sloooow) - chröme wrote:
> > I'm trying to figure out why this file got moved to the 'use_alsa' section,
> but
> > don't see why.  Any chance you remember why it had to be moved?
> 
> The same condition was in GYP in that time, see
>
https://chromium.googlesource.com/chromium/src/+/2a25593b2d7f5c5f963f6c6dfc33...
> 
> I just moved it to GN, may be there was some compilation error in that time on
> some plarform - I can't remember exactly.
> 
> Initially this condition was introduced in this CL
> https://chromiumcodereview.appspot.com/12316049/diff/1/media/media.gyp , may
be
> it worth to ask about it there.

Thanks for the reply. I'll take a look.

Powered by Google App Engine
This is Rietveld 408576698