Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 844563003: DevTools: Fix console not showing array items inherited from prototype. (Closed)

Created:
5 years, 11 months ago by aandrey
Modified:
5 years, 11 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Fix console not showing array items inherited from prototype. BUG=320632 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188228

Patch Set 1 : #

Patch Set 2 : include non-own non-enumerable index properties to array preview #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -19 lines) Patch
A LayoutTests/inspector/console/console-format-array-prototype.html View 1 2 1 chunk +90 lines, -0 lines 0 comments Download
A LayoutTests/inspector/console/console-format-array-prototype-expected.txt View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 1 3 chunks +10 lines, -6 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleViewMessage.js View 3 chunks +38 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sdk/RemoteObject.js View 2 chunks +15 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
aandrey
5 years, 11 months ago (2015-01-10 14:07:01 UTC) #1
pfeldman
lgtm
5 years, 11 months ago (2015-01-12 14:01:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844563003/80001
5 years, 11 months ago (2015-01-12 14:04:04 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 15:50:04 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188228

Powered by Google App Engine
This is Rietveld 408576698