Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 844533005: Disable the new delayed load strategy for PersistentCookieStore. (Closed)

Created:
5 years, 11 months ago by erikchen
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable the new delayed load strategy for PersistentCookieStore. I recently introduced a change which caused SQLitePersistentCookieStore to load the cookies for one eTLD every 200ms, instead of every 0ms. That change appeared to cause a hang during shutdown. This CL changes the delay from 200ms back to 0ms while I investigate the hang. BUG=436152, 448910 Committed: https://crrev.com/d551c7628b6a71f111bed91bec3eda7b8ee1ca26 Cr-Commit-Position: refs/heads/master@{#312903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/browser/net/sqlite_persistent_cookie_store.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
erikchen
erikwright: Please review.
5 years, 11 months ago (2015-01-20 22:13:15 UTC) #2
erikwright (departed)
LGTM.
5 years, 11 months ago (2015-01-22 15:35:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844533005/1
5 years, 11 months ago (2015-01-22 17:24:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/116651) linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/102456) Try ...
5 years, 11 months ago (2015-01-22 18:48:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844533005/1
5 years, 11 months ago (2015-01-23 19:19:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/116651) linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/102456)
5 years, 11 months ago (2015-01-23 19:20:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844533005/1
5 years, 11 months ago (2015-01-23 19:25:38 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 19:48:43 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d551c7628b6a71f111bed91bec3eda7b8ee1ca26 Cr-Commit-Position: refs/heads/master@{#312903}
5 years, 11 months ago (2015-01-23 19:49:33 UTC) #15
Raphael Kubo da Costa (rakuco)
5 years, 11 months ago (2015-01-27 17:31:41 UTC) #17
Message was sent while issue was closed.
Commenting here since I don't have access to the bugs: are you planning on
merging this to M41? I'm experiencing the same hangs (which in debug mode turn
into crashes) with a downstream project (Crosswalk).

Powered by Google App Engine
This is Rietveld 408576698