Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Issue 844503007: Fix CRD opens a window every time it's clicked in the launcher (Closed)

Created:
5 years, 11 months ago by kelvinp
Modified:
5 years, 11 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix CRD opens a window every time it's clicked in the launcher Cause: This is a regression of the HRD change, in which we pass in an unique ID everytime when we create an app window. This causes a new window to be created whenever the user clicks on the app icon in the app launcher. Fix: Only create a new app window when: 1. There are no existing windows or 2. The user clicks on the New Window context menu BUG=448128 Committed: https://crrev.com/81b9425c45c6ec20805385070ee69085c2cc426a Cr-Commit-Position: refs/heads/master@{#311545}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address CL feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -26 lines) Patch
M remoting/webapp/crd/js/background.js View 1 2 chunks +49 lines, -25 lines 0 comments Download
M remoting/webapp/js_proto/chrome_proto.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
kelvinp
PTAL
5 years, 11 months ago (2015-01-14 00:51:41 UTC) #1
Jamie
lgtm https://codereview.chromium.org/844503007/diff/1/remoting/webapp/crd/js/background.js File remoting/webapp/crd/js/background.js (right): https://codereview.chromium.org/844503007/diff/1/remoting/webapp/crd/js/background.js#newcode57 remoting/webapp/crd/js/background.js:57: return; I think an else would be more ...
5 years, 11 months ago (2015-01-14 03:07:24 UTC) #3
kelvinp
FYI
5 years, 11 months ago (2015-01-14 19:41:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844503007/20001
5 years, 11 months ago (2015-01-14 19:41:40 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 21:05:50 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 21:06:49 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81b9425c45c6ec20805385070ee69085c2cc426a
Cr-Commit-Position: refs/heads/master@{#311545}

Powered by Google App Engine
This is Rietveld 408576698