Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 844503004: Revert of cc: Re-enable prepaint for GPU rasterization (Closed)

Created:
5 years, 11 months ago by hendrikw
Modified:
5 years, 11 months ago
Reviewers:
vmpstr, vmiura
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Re-enable prepaint for GPU rasterization (patchset #1 id:1 of https://codereview.chromium.org/837533002/) Reason for revert: Better to leave this in, and now we know that this doesn't improve telemetry significantly Original issue's description: > cc: Re-enable prepaint for GPU rasterization > > The synchronous rasterization change for GPU rasterization tries > to avoid prepainting, which may have caused longer frame times in > some of the tests. > > We'll re-enable prepainting to see if this is the reason. This > will probably be reverted. > > Committed: https://crrev.com/dee056c614737f8bf07686d38dfcc4d264c51813 > Cr-Commit-Position: refs/heads/master@{#309956} TBR=vmpstr@chromium.org,vmiura@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b4e1d0be081c7a143cdad31e078411158a1491f9 Cr-Commit-Position: refs/heads/master@{#310407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M cc/resources/tile_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/tile_manager.cc View 6 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hendrikw
Created Revert of cc: Re-enable prepaint for GPU rasterization
5 years, 11 months ago (2015-01-07 23:22:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844503004/1
5 years, 11 months ago (2015-01-07 23:23:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 23:24:23 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 23:25:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4e1d0be081c7a143cdad31e078411158a1491f9
Cr-Commit-Position: refs/heads/master@{#310407}

Powered by Google App Engine
This is Rietveld 408576698